tools/perf/measurements/thread_times.py - Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/perf/measurements/thread_times.py

Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/perf/measurements/smoothness_controller.py ('k') | tools/perf/measurements/timeline_controller.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from measurements import timeline_controller	4 from measurements import timeline_controller

5 from metrics import timeline	5 from metrics import timeline

6 from telemetry.core.backends.chrome import tracing_backend	6 from telemetry.core.backends.chrome import tracing_backend

7 from telemetry.page import page_measurement	7 from telemetry.page import page_measurement

8	8

9 class ThreadTimes(page_measurement.PageMeasurement):	9 class ThreadTimes(page_measurement.PageMeasurement):

10 def __init__(self):	10 def __init__(self):

(...skipping 19 matching lines...) Expand all Loading...
30 self._timeline_controller.SetUp(page, tab)	30 self._timeline_controller.SetUp(page, tab)

31	31

32 def WillRunActions(self, page, tab):	32 def WillRunActions(self, page, tab):

33 self._timeline_controller.Start(tab)	33 self._timeline_controller.Start(tab)

34	34

35 def DidRunActions(self, page, tab):	35 def DidRunActions(self, page, tab):

36 self._timeline_controller.Stop(tab)	36 self._timeline_controller.Stop(tab)

37	37

38 def MeasurePage(self, page, tab, results):	38 def MeasurePage(self, page, tab, results):

39 metric = timeline.ThreadTimesTimelineMetric()	39 metric = timeline.ThreadTimesTimelineMetric()

40 renderer_thread = \

41 self._timeline_controller.model.GetRendererThreadFromTabId(tab.id)

42 if self.options.report_silk_results:	40 if self.options.report_silk_results:

43 metric.results_to_report = timeline.ReportSilkResults	41 metric.results_to_report = timeline.ReportSilkResults

44 if self.options.report_silk_details:	42 if self.options.report_silk_details:

45 metric.details_to_report = timeline.ReportSilkDetails	43 metric.details_to_report = timeline.ReportSilkDetails

46 metric.AddResults(self._timeline_controller.model, renderer_thread,	44 metric.AddResults(self._timeline_controller.model,

47 self._timeline_controller.smooth_records, results)	45 self._timeline_controller.smooth_records, results)

48	46

49 def CleanUpAfterPage(self, _, tab):	47 def CleanUpAfterPage(self, _, tab):

50 self._timeline_controller.CleanUp(tab)	48 self._timeline_controller.CleanUp(tab)

OLD	NEW