tools/telemetry/telemetry/web_perf/metrics/smoothness.py - Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/web_perf/metrics/smoothness.py

Issue 439383002: Add GetThreadToInteractionRecordsMapsFromModel method to timeline_interaction_record. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/web_perf/metrics/smoothness.py

diff --git a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

index 6bde6d6bb714ed3c88022d525879b3148bb709fd..5b8abb252fe2029cb460c46b64b1441c2326024e 100644

--- a/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

+++ b/tools/telemetry/telemetry/web_perf/metrics/smoothness.py

@@ -14,8 +14,10 @@ class SmoothnessMetric(timeline_based_metric.TimelineBasedMetric):

def __init__(self):

super(SmoothnessMetric, self).__init__()

- def AddResults(self, model, renderer_thread, interaction_records, results):

+ def AddResults(self, model, interaction_records, results):

self.VerifyNonOverlappedRecords(interaction_records)

+ self.VerifyAllRecordsIssuedBySameThread(interaction_records)

+ renderer_thread = interaction_records[0].async_event.start_thread

renderer_process = renderer_thread.parent

stats = rendering_stats.RenderingStats(

renderer_process, model.browser_process,

« no previous file with comments | « tools/perf/metrics/timeline.py ('k') | tools/telemetry/telemetry/web_perf/metrics/timeline_based_metric.py » ('j') | no next file with comments »