Patch for allowing several V8 instances in process:...

Straightforward patch for allowing several V8 instances in process with retaining external API:
- Introduced V8ContextProvider, V8ContextBinder, AllowSeveralV8InstancesInProcess classes to public api (include\v8.h),
- Created v8::internal::V8Context class to hold the data of separate objects of v8 instance

- Created v8_context() inline function to return V8Context for accessing the data, 
in case there is no AllowSeveralV8InstancesInProcess classes statically instantiated the function just returns global 
pointer otherwise the data is retrieved from thread local variable
- Wrapped with locking dtoa calls in conversions.cc and pointer bounds handling/time calc activities in platform-win32.cc, 
effectively doing mutex locking when AllowSeveralV8InstancesInProcess was instantiated
- Most of all other changes like moved static data of class/file XXX to XXXData.
- Moved static data of v8::internal::V8, static flag from v8::Locker, static callback pointer 
 exception_behavior from api.cc into v8::internal::V8Data as instance variables

- Moved static data of v8::internal::ThreadManager, v8::internal::ContextSwitcher, v8::internal::ThreadState,
static Thread::LocalStorageKey variables into v8::internal::ThreadManagerData
- Moved static data of v8::internal::Heap into v8::internal::HeapData as instance variables.
- MarkObjectVisitor and UnmarkObjectVisitor allocated on stack instead of static variables.
- static void MarkObjectRecursively(Object** p); becomes member of v8::internal::MarkObjectVisitor
- static void UnmarkObjectRecursively(Object** p); becomes member of v8::internal::UnmarkObjectVisitor
- Moved static data of heap.cc into v8::internal::PrivateHeapData as instance variables.
- static void MarkRootObjectRecursively(Object** root); moved to v8::internal::PrivateHeapData

- static data and types of v8::internal::TranscendentalCache moved to v8::internal::TranscendentalCacheData as 
instance variables / types.
- static data and types of v8::internal::DescriptorLookupCache moved to v8::internal::DescriptorLookupCacheData 
as instance variables / types.
- static data and types of v8::internal::KeyedLookupCacheData moved to v8::internal::KeyedLookupCacheDataData as 
instance variables / types

- static data of v8::internal::Zone, v8::internal::ZoneScope, v8::internal::Zone, 
  v8::internal::AssertNoZoneAllocation, v8::internal::Segment moved to v8:internal::ZoneData
- static data of v8::internal::Top moved to v8::internal::TopData, static data of top.cc moved to
  v8::internal::TopPrivateData as instance variables
- static data of v8::internal::StackGuard moved to v8::internal::StackGuard and static data of execution.cc moved
  to v8::internal::StackGuardPrivateData as instance variables
- static data of v8::internal::RegExpStack and static data of regexp-macro-assembler.cc, jsregexp.cc moved to
  v8::internal::RegExpStackData as instance variables

- static data of v8::internal::Serializer moved to class v8::internal::SerializerData, static data of serializer.cc 
(ExternalReferenceTable, SerializationAddressMapper) moved to v8::internal::SerializerPrivateData
- static data of v8::internal::ContextSlotCache moved to v8::internal::ContextSlotCacheData
- HandleScopeImplementer singleton is member of v8::internal::V8Context now
- Static data of v8::internal::StubCache and v8::internal::CompilationCache become instance data of 
v8::internal::StubCacheData and v8::internal::CompilationCachePrivateData
- All mutable statics of v8::internal::GlobalHandles become instance data of v8::internal::GlobalHandlesData
- All mutable statics of v8::internal::MemoryAllocator become instance data of v8::internal::MemoryAllocatorData
- All mutable statics of v8::internal::CodeRange become instance data of v8::internal::CodeRangeData
- All mutable statics of v8::internal::MarkCompactCollector become instance data of v8::internal::MarkCompactCollectorData
- All mutable statics of v8::internal::RelocatableData become instance data of v8::internal::RelocatableData
- All mutable statics of v8::internal::CodeGenerator become instance data of v8::internal::CodeGeneratorData

- All mutable statics of v8::internal::Bootstrapper become instance data of v8::internal::BootstrapperData
- All mutable statics of v8::internal::Scanner become instance data of v8::internal::ScannerData
- All mutable statics of v8::internal::Compiler become instance data of v8::internal::CompilerData
- All mutable statics of v8::internal::PreallocatedStorage, v8::internal::Page, v8::internal::NativeAllocationChecker 
become instance data of v8::internal::StorageData
- All mutable statics of v8::internal::StatsTable become instance data of v8::internal::StatsTableData
- All mutable statics of v8::internal::Runtime become instance data of v8::internal::RuntimeData

- All mutable statics of v8::internal::Assembler become instance data of v8::internal::AssemblerData
- All mutable statics of api.cc become instance data of v8::internal::ApiData, except extensions
- All mutable statics of v8::internal::Bultins become instance data of v8::internal::BuiltinsData
- All mutable statics of v8::internal::Debug become instance data of v8::internal::DebugData
- All mutable statics of v8::internal::Debugger become instance data of v8::internal::DebuggerData

At this point 10 instances of V8 can run the benchmark for i386/Win32 :)

- Extensions processed in bootstrapper with v8shareddata lock if needed
- Counters class instance become a member of V8Context
- static instance of GlobalHandler::Pool moved to v8::internal::GlobalInstancePrivateData
- shell / cctest able to run with custom number of v8instances (not all tests are ready for this :)
- Statics of Logger and Log class moved to LoggerData/LogData
- Put all changes to forked V8 repository git://github.com/nicity/Embeddable-V8.git
- Handled shared data for Assembler on 64bit / Arm cpu
- Proper locking for reading/writing heap bounds for MacOS, Linux, BSD

BUG=http://code.google.com/p/v8/issues/detail?id=510
TEST=All tests should pass

[Maxim.Mossienko, 2009-11-25 12:01:30]

Please, review the code till the patch has not grown too much :)

[Maxim.Mossienko, 2009-11-27 19:21:02]

Continuing extraction of static data 
- static data of v8::internal::Top moved to v8::internal::TopData, static data
of top.cc moved to
  v8::internal::TopPrivateData as instance variables
- static data of v8::internal::StackGuard moved to v8::internal::StackGuard and
static data of execution.cc moved
  to v8::internal::StackGuardPrivateData as instance variables
- static data of v8::internal::RegExpStack and static data of
regexp-macro-assembler.cc, jsregexp.cc moved to
  v8::internal::RegExpStackData as instance variables

- static data of v8::internal::Serializer moved to class
v8::internal::SerializerData, static data of serializer.cc 
(ExternalReferenceTable, SerializationAddressMapper) moved to
v8::internal::SerializerPrivateData
- static data of v8::internal::ContextSlotCache moved to
v8::internal::ContextSlotCacheData
- HandleScopeImplementer singleton is member of v8::internal::V8Context now
- Static data of v8::internal::StubCache and v8::internal::CompilationCache
become instance data of 
v8::internal::StubCacheData and v8::internal::CompilationCachePrivateData
- All statics of v8::internal::GlobalHandles become instance data of
v8::internal::GlobalHandlesData

[Maxim.Mossienko, 2009-11-30 12:30:51]

- All mutable statics of v8::internal::MemoryAllocator become instance data of
v8::internal::MemoryAllocatorData
- All mutable statics of v8::internal::CodeRange become instance data of
v8::internal::CodeRangeData
- All mutable statics of v8::internal::MarkCompactCollector become instance data
of v8::internal::MarkCompactCollectorData
- All mutable statics of v8::internal::RelocatableData become instance data of
v8::internal::RelocatableData
- All mutable statics of v8::internal::CodeGenerator become instance data of
v8::internal::CodeGeneratorData

- All mutable statics of v8::internal::Bootstrapper become instance data of
v8::internal::BootstrapperData
- All mutable statics of v8::internal::Scanner become instance data of
v8::internal::ScannerData
- All mutable statics of v8::internal::Compiler become instance data of
v8::internal::CompilerData
- All mutable statics of v8::internal::PreallocatedStorage, v8::internal::Page,
v8::internal::NativeAllocationChecker
become instance data of v8::internal::StorageData
- All mutable statics of v8::internal::StatsTable become instance data of
v8::internal::StatsTableData
- All mutable statics of v8::internal::Runtime become instance data of
v8::internal::RuntimeData

- All mutable statics of v8::internal::Assembler become instance data of
v8::internal::AssemblerData
- All mutable statics of api.cc become instance data of v8::internal::ApiData,
except extensions
- All mutable statics of v8::internal::Bultins become instance data of
v8::internal::BuiltinsData
- All mutable statics of v8::internal::Debug become instance data of
v8::internal::DebugData
- All mutable statics of v8::internal::Debugger become instance data of
v8::internal::DebuggerData

At this point 10 instances of V8 can run the benchmark on i386, of course all
tests works with or without SEVERAL_V8_IN_PROCESS, also on i386 :)

[Maxim.Mossienko, 2009-11-30 20:02:40]

- No more preprocessor directive SEVERAL_V8_IN_PROCESS needed, just static
declaration like AllowSeveralV8InstancesInProcess v8_please; switches support
for several v8 in process on. Tests are passed with/without for Win32/i386.
- Locking for updating heap bounds / timezone information in platform-win32.cc

[Maxim.Mossienko, 2009-12-03 20:09:08]

- Extensions processed in bootstrapper with v8shareddata lock if needed
- Counters class instance become a member of V8Context
- static instance of GlobalHandler::Pool moved to
v8::internal::GlobalInstancePrivateData
- shell / cctest able to run with custom number of v8instances (not all tests
are ready for this :)

[Maxim.Mossienko, 2009-12-04 19:16:27]

- Statics of Logger and Log class moved to LoggerData/LogData
- Put all changes to forked V8 git repository
git://github.com/nicity/Embeddable-V8.git

[Maxim.Mossienko, 2009-12-08 17:15:43]

- Handled shared data for Assembler on 64bit / Arm cpu
- Proper locking for reading/writing heap bounds for MacOS, Linux, BSD

[Bahaa Naamneh, 2010-01-13 13:14:10]

1. allocation.h:
  "static int allocation_disallowed_;" 
  should be removed from  NativeAllocationChecker class.
		
2. heap.h:
  a new class named ExternalStringTable has been added which contains
  2 static data members:
    static List<Object*> new_space_strings_;
    static List<Object*> old_space_strings_;
  		
3. spaces.h:
  "static RSetState rset_state_;" should be removed form Page class.
		
4. bootstrapper.cc:
  a new static variable: 
    List<char*>* delete_these_arrays_on_tear_down_;
		
5. In AssemblerData, the data member spare_buffer_ should be release 
   by calling "DeleteArray" and not "delete" since it is allocated 
   by NewArray:
    ~AssemblerData() { DeleteArray(spare_buffer_); }
		
6. Where do you release the allocated dynamic memory in: ?
   Counters::Counters()
    : state_counters(new StatsCounter[state_counters_count]) { 
  
   You should add a destructor for Counters class to deallocated 
   the memory.
  
7. The order of the member variables in your added classes do not 
   match with the order they are written in the initialisation list in 
   the constructor, 
   and that cause the compilation under gcc to fail. you should 
   reorder your initialisation lists or add '-Wno-reorder' flag to gcc 
   compilation flags.
	 

8. Note: a call to V8::Dispose() should be called explicitly at the 
   end if each thread that creates an V8 instance to deallocate all 
   the used memory.


9. There are some memory-leaks in V8 code which we have to take care 
   of:
    
http://groups.google.com/group/v8-users/browse_thread/thread/04347322e009198c#
   The one discussed in the link above is a minor memory leak indeed 
   but with a heavily used threads application it might be a problem.
	 
10. Valgrind reported the following memory leaks:
60 bytes in 5 blocks are definitely lost in loss record 3 of 17
   at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
   by 0x81C4EC6: v8::internal::CodeGeneratorData::result_constants_list()
(codegen.cc:70)
   by 0x8153134: v8::internal::Result::ConstantList() (register-allocator.cc:48)
   by 0x80778FA: v8::internal::Result::ClearConstantList()
(register-allocator.h:99)
   by 0x80774B8: v8::internal::CompilationZoneScope::~CompilationZoneScope()
(compiler.h:127)
   by 0x8073879: v8::internal::ScanMakeFunction(bool, bool,
v8::internal::Compiler::ValidationState,
v8::internal::Handle<v8::internal::Script>,
v8::internal::Handle<v8::internal::Context>, v8::Extension*,
v8::internal::ScriptDataImpl*) (compiler.cc:313)
   by 0x8073D10:
v8::internal::Compiler::ScanCompile(v8::internal::Handle<v8::internal::String>,
v8::internal::Handle<v8::internal::Object>, int, int, v8::Extension*,
v8::internal::ScriptDataImpl*) (compiler.cc:409)
   by 0x804EDC7: v8::Script::ScanNew(v8::Handle<v8::String>, v8::ScriptOrigin*,
v8::ScriptData*) (api.cc:1273)


60 bytes in 5 blocks are definitely lost in loss record 4 of 17
   at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
   by 0x81C4F04: v8::internal::CodeGeneratorData::frame_element_constants_list()
(codegen.cc:76)
   by 0x80965F4: v8::internal::FrameElement::ConstantList()
(frame-element.cc:40)
   by 0x807791A: v8::internal::FrameElement::ClearConstantList()
(frame-element.h:98)
   by 0x80774B3: v8::internal::CompilationZoneScope::~CompilationZoneScope()
(compiler.h:126)
   by 0x8073879: v8::internal::ScanMakeFunction(bool, bool,
v8::internal::Compiler::ValidationState,
v8::internal::Handle<v8::internal::Script>,
v8::internal::Handle<v8::internal::Context>, v8::Extension*,
v8::internal::ScriptDataImpl*) (compiler.cc:313)
   by 0x8073D10:
v8::internal::Compiler::ScanCompile(v8::internal::Handle<v8::internal::String>,
v8::internal::Handle<v8::internal::Object>, int, int, v8::Extension*,
v8::internal::ScriptDataImpl*) (compiler.cc:409)
   by 0x804EDC7: v8::Script::ScanNew(v8::Handle<v8::String>, v8::ScriptOrigin*,
v8::ScriptData*) (api.cc:1273)


120 bytes in 6 blocks are definitely lost in loss record 6 of 17
   at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
   by 0x81514C4: v8::internal::OS::CreateSemaphore(int) (platform-linux.cc:640)
   by 0x807E229: v8::internal::DebuggerData::DebuggerData() (debug.cc:1804)
   by 0x81B652F: v8::internal::V8Context::V8Context() (v8-global-context.cc:117)
   by 0x81B7050: __static_initialization_and_destruction_0(int, int)
(v8-global-context.cc:29)
   by 0x81B7118: _GLOBAL__I__ZN2v87tls_keyE (objects.h:1939)


300 bytes in 5 blocks are definitely lost in loss record 10 of 17
   at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
   by 0x81F9A19: v8::internal::ExternalReferenceTable::instance()
(serialize.cc:158)
   by 0x81F67DD:
v8::internal::ExternalReferenceDecoder::ExternalReferenceDecoder()
(serialize.cc:560)
   by 0x81F6E03: v8::internal::Deserializer::Deserialize() (serialize.cc:669)
   by 0x81B77D2: v8::internal::V8::Initialize(v8::internal::Deserializer*)
(v8.cc:107)
   by 0x819D3AB: v8::internal::Snapshot::Deserialize(unsigned char const*, int)
(snapshot-common.cc:43)
   by 0x819D441: v8::internal::Snapshot::Initialize(char const*)
(snapshot-common.cc:56)
   by 0x80551E7: v8::V8::Initialize() (api.cc:2737)


504 bytes in 18 blocks are definitely lost in loss record 12 of 17
   at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
   by 0x81512F4: v8::internal::OS::CreateMutex() (platform-linux.cc:570)
   by 0x81B840D: v8::internal::ThreadManagerData::ThreadManagerData()
(v8threads.cc:275)
   by 0x81B605F: v8::internal::V8Context::V8Context() (v8-global-context.cc:117)
   by 0x81B7050: __static_initialization_and_destruction_0(int, int)
(v8-global-context.cc:29)


81904 bytes in 1 blocks are possibly lost in loss record 16 of 17
   at 0x1B903D38: malloc (vg_replace_malloc.c:131)
   by 0x81BD241: v8::internal::Malloced::New(unsigned) (allocation.cc:38)
   by 0x8081CA6: v8::internal::Malloced::operator new(unsigned)
(allocation.h:40)
   by 0x809B4E0: v8::internal::GlobalHandles::Pool::Pool()
(global-handles.cc:219)
   by 0x809B456:
v8::internal::GlobalHandlesPrivateData::GlobalHandlesPrivateData()
(global-handles.cc:450)
   by 0x809A426: v8::internal::GlobalHandlesData::GlobalHandlesData()
(global-handles.cc:450)
   by 0x81B61F9: v8::internal::V8Context::V8Context() (v8-global-context.cc:117)
   by 0x81B7050: __static_initialization_and_destruction_0(int, int)
(v8-global-context.cc:29)


82180 bytes in 5 blocks are definitely lost in loss record 17 of 17
   at 0x1B903D38: malloc (vg_replace_malloc.c:131)
   by 0x81BD241: v8::internal::Malloced::New(unsigned) (allocation.cc:38)
   by 0x81BB33C: v8::internal::Segment::New(int) (zone.cc:70)
   by 0x81BB00D: v8::internal::Zone::NewExpand(int) (zone.cc:182)
   by 0x8077CE2: v8::internal::Zone::New(int) (zone-inl.h:48)
   by 0x80E3D94: v8::internal::ZoneObject::operator new(unsigned) (zone.h:142)
   by 0x819A800:
v8::internal::Scope::NewUnresolved(v8::internal::Handle<v8::internal::String>,
bool) (scopes.cc:255)
   by 0x8144D7A: v8::internal::Parser::ParsePrimaryExpression(bool*)
(parser.cc:3193)


please take a look at them.



There are still some minor things which I do not remember and didn't write them
down since I wasn't focused on reviewing your code, but I was using your code as
a reference during changing V8's code into thread-safe code.

[Bahaa Naamneh, 2010-01-13 16:41:38]

You have many memory leaks in your code, examples:
1. DebuggerData::DebuggerData():debugger_access_(OS::CreateMutex()),
2. TopData::TopData():break_access_(OS::CreateMutex()),
3. ThreadManagerData::ThreadManagerData():mutex_(OS::CreateMutex()),

Mutex* OS::CreateMutex() {
  return new LinuxMutex();
}

You didn't release the allocated mutex objects.

In the original code of V8 these variables were static, and as of that they
haven't released them explicitly since the operating system will do so
when the process is terminated, but here in our case we have to release every
dynamic allocated memory explicitly.

Regards,
Bahaa

On 2010/01/13 13:14:10, Bahaa Naamneh wrote:
> 1. allocation.h:
>   "static int allocation_disallowed_;" 
>   should be removed from  NativeAllocationChecker class.
> 		
> 2. heap.h:
>   a new class named ExternalStringTable has been added which contains
>   2 static data members:
>     static List<Object*> new_space_strings_;
>     static List<Object*> old_space_strings_;
>   		
> 3. spaces.h:
>   "static RSetState rset_state_;" should be removed form Page class.
> 		
> 4. bootstrapper.cc:
>   a new static variable: 
>     List<char*>* delete_these_arrays_on_tear_down_;
> 		
> 5. In AssemblerData, the data member spare_buffer_ should be release 
>    by calling "DeleteArray" and not "delete" since it is allocated 
>    by NewArray:
>     ~AssemblerData() { DeleteArray(spare_buffer_); }
> 		
> 6. Where do you release the allocated dynamic memory in: ?
>    Counters::Counters()
>     : state_counters(new StatsCounter[state_counters_count]) { 
>   
>    You should add a destructor for Counters class to deallocated 
>    the memory.
>   
> 7. The order of the member variables in your added classes do not 
>    match with the order they are written in the initialisation list in 
>    the constructor, 
>    and that cause the compilation under gcc to fail. you should 
>    reorder your initialisation lists or add '-Wno-reorder' flag to gcc 
>    compilation flags.
> 	 
> 
> 8. Note: a call to V8::Dispose() should be called explicitly at the 
>    end if each thread that creates an V8 instance to deallocate all 
>    the used memory.
> 
> 
> 9. There are some memory-leaks in V8 code which we have to take care 
>    of:
>     
> http://groups.google.com/group/v8-users/browse_thread/thread/04347322e009198c#
>    The one discussed in the link above is a minor memory leak indeed 
>    but with a heavily used threads application it might be a problem.
> 	 
> 10. Valgrind reported the following memory leaks:
> 60 bytes in 5 blocks are definitely lost in loss record 3 of 17
>    at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
>    by 0x81C4EC6: v8::internal::CodeGeneratorData::result_constants_list()
> (codegen.cc:70)
>    by 0x8153134: v8::internal::Result::ConstantList()
(register-allocator.cc:48)
>    by 0x80778FA: v8::internal::Result::ClearConstantList()
> (register-allocator.h:99)
>    by 0x80774B8: v8::internal::CompilationZoneScope::~CompilationZoneScope()
> (compiler.h:127)
>    by 0x8073879: v8::internal::ScanMakeFunction(bool, bool,
> v8::internal::Compiler::ValidationState,
> v8::internal::Handle<v8::internal::Script>,
> v8::internal::Handle<v8::internal::Context>, v8::Extension*,
> v8::internal::ScriptDataImpl*) (compiler.cc:313)
>    by 0x8073D10:
>
v8::internal::Compiler::ScanCompile(v8::internal::Handle<v8::internal::String>,
> v8::internal::Handle<v8::internal::Object>, int, int, v8::Extension*,
> v8::internal::ScriptDataImpl*) (compiler.cc:409)
>    by 0x804EDC7: v8::Script::ScanNew(v8::Handle<v8::String>,
v8::ScriptOrigin*,
> v8::ScriptData*) (api.cc:1273)
> 
> 
> 60 bytes in 5 blocks are definitely lost in loss record 4 of 17
>    at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
>    by 0x81C4F04:
v8::internal::CodeGeneratorData::frame_element_constants_list()
> (codegen.cc:76)
>    by 0x80965F4: v8::internal::FrameElement::ConstantList()
> (frame-element.cc:40)
>    by 0x807791A: v8::internal::FrameElement::ClearConstantList()
> (frame-element.h:98)
>    by 0x80774B3: v8::internal::CompilationZoneScope::~CompilationZoneScope()
> (compiler.h:126)
>    by 0x8073879: v8::internal::ScanMakeFunction(bool, bool,
> v8::internal::Compiler::ValidationState,
> v8::internal::Handle<v8::internal::Script>,
> v8::internal::Handle<v8::internal::Context>, v8::Extension*,
> v8::internal::ScriptDataImpl*) (compiler.cc:313)
>    by 0x8073D10:
>
v8::internal::Compiler::ScanCompile(v8::internal::Handle<v8::internal::String>,
> v8::internal::Handle<v8::internal::Object>, int, int, v8::Extension*,
> v8::internal::ScriptDataImpl*) (compiler.cc:409)
>    by 0x804EDC7: v8::Script::ScanNew(v8::Handle<v8::String>,
v8::ScriptOrigin*,
> v8::ScriptData*) (api.cc:1273)
> 
> 
> 120 bytes in 6 blocks are definitely lost in loss record 6 of 17
>    at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
>    by 0x81514C4: v8::internal::OS::CreateSemaphore(int)
(platform-linux.cc:640)
>    by 0x807E229: v8::internal::DebuggerData::DebuggerData() (debug.cc:1804)
>    by 0x81B652F: v8::internal::V8Context::V8Context()
(v8-global-context.cc:117)
>    by 0x81B7050: __static_initialization_and_destruction_0(int, int)
> (v8-global-context.cc:29)
>    by 0x81B7118: _GLOBAL__I__ZN2v87tls_keyE (objects.h:1939)
> 
> 
> 300 bytes in 5 blocks are definitely lost in loss record 10 of 17
>    at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
>    by 0x81F9A19: v8::internal::ExternalReferenceTable::instance()
> (serialize.cc:158)
>    by 0x81F67DD:
> v8::internal::ExternalReferenceDecoder::ExternalReferenceDecoder()
> (serialize.cc:560)
>    by 0x81F6E03: v8::internal::Deserializer::Deserialize() (serialize.cc:669)
>    by 0x81B77D2: v8::internal::V8::Initialize(v8::internal::Deserializer*)
> (v8.cc:107)
>    by 0x819D3AB: v8::internal::Snapshot::Deserialize(unsigned char const*,
int)
> (snapshot-common.cc:43)
>    by 0x819D441: v8::internal::Snapshot::Initialize(char const*)
> (snapshot-common.cc:56)
>    by 0x80551E7: v8::V8::Initialize() (api.cc:2737)
> 
> 
> 504 bytes in 18 blocks are definitely lost in loss record 12 of 17
>    at 0x1B903EB2: operator new(unsigned) (vg_replace_malloc.c:133)
>    by 0x81512F4: v8::internal::OS::CreateMutex() (platform-linux.cc:570)
>    by 0x81B840D: v8::internal::ThreadManagerData::ThreadManagerData()
> (v8threads.cc:275)
>    by 0x81B605F: v8::internal::V8Context::V8Context()
(v8-global-context.cc:117)
>    by 0x81B7050: __static_initialization_and_destruction_0(int, int)
> (v8-global-context.cc:29)
> 
> 
> 81904 bytes in 1 blocks are possibly lost in loss record 16 of 17
>    at 0x1B903D38: malloc (vg_replace_malloc.c:131)
>    by 0x81BD241: v8::internal::Malloced::New(unsigned) (allocation.cc:38)
>    by 0x8081CA6: v8::internal::Malloced::operator new(unsigned)
> (allocation.h:40)
>    by 0x809B4E0: v8::internal::GlobalHandles::Pool::Pool()
> (global-handles.cc:219)
>    by 0x809B456:
> v8::internal::GlobalHandlesPrivateData::GlobalHandlesPrivateData()
> (global-handles.cc:450)
>    by 0x809A426: v8::internal::GlobalHandlesData::GlobalHandlesData()
> (global-handles.cc:450)
>    by 0x81B61F9: v8::internal::V8Context::V8Context()
(v8-global-context.cc:117)
>    by 0x81B7050: __static_initialization_and_destruction_0(int, int)
> (v8-global-context.cc:29)
> 
> 
> 82180 bytes in 5 blocks are definitely lost in loss record 17 of 17
>    at 0x1B903D38: malloc (vg_replace_malloc.c:131)
>    by 0x81BD241: v8::internal::Malloced::New(unsigned) (allocation.cc:38)
>    by 0x81BB33C: v8::internal::Segment::New(int) (zone.cc:70)
>    by 0x81BB00D: v8::internal::Zone::NewExpand(int) (zone.cc:182)
>    by 0x8077CE2: v8::internal::Zone::New(int) (zone-inl.h:48)
>    by 0x80E3D94: v8::internal::ZoneObject::operator new(unsigned) (zone.h:142)
>    by 0x819A800:
> v8::internal::Scope::NewUnresolved(v8::internal::Handle<v8::internal::String>,
> bool) (scopes.cc:255)
>    by 0x8144D7A: v8::internal::Parser::ParsePrimaryExpression(bool*)
> (parser.cc:3193)
> 
> 
> please take a look at them.
> 
> 
> 
> There are still some minor things which I do not remember and didn't write
them
> down since I wasn't focused on reviewing your code, but I was using your code
as
> a reference during changing V8's code into thread-safe code.