Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 433733002: Revert 284592 "Cache the current WebPreferences on RenderViewHos..." (Closed)

Created:
6 years, 4 months ago by matthewyuan
Modified:
6 years, 4 months ago
Reviewers:
chrishtr
CC:
chromium-reviews, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, android-webview-reviews_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert 284592 "Cache the current WebPreferences on RenderViewHos..." > Cache the current WebPreferences on RenderViewHostImpl. > > This makes lookups of a WebPreferences field fast. > In order do this, add code to listen to all preferences updates in order to recompute the cache. > > BUG=390799 > > Review URL: https://codereview.chromium.org/373323003 TBR=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=286687

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -72 lines) Patch
M android_webview/native/aw_settings.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 7 chunks +8 lines, -18 lines 0 comments Download
M content/browser/android/content_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +1 line, -4 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/browser/render_view_host.h View 1 chunk +1 line, -6 lines 0 comments Download
M content/public/test/web_contents_tester.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/test/test_web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_web_contents.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
matthewyuan
6 years, 4 months ago (2014-07-31 02:47:13 UTC) #1
matthewyuan
6 years, 4 months ago (2014-07-31 02:47:34 UTC) #2
Message was sent while issue was closed. 
Committed patchset #1 manually as r286687 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698