chrome/browser/android/voice_search_tab_helper.cc - Issue 433733002: Revert 284592 "Cache the current WebPreferences on RenderViewHos..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/voice_search_tab_helper.cc

Issue 433733002: Revert 284592 "Cache the current WebPreferences on RenderViewHos..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2107/src/

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/voice_search_tab_helper.cc

===================================================================

--- chrome/browser/android/voice_search_tab_helper.cc (revision 286686)

+++ chrome/browser/android/voice_search_tab_helper.cc (working copy)

@@ -32,8 +32,6 @@

if (!prefs.user_gesture_required_for_media_playback)

return;

- // TODO(chrishtr): this is wrong. user_gesture_required_for_media_playback

- // will be reset the next time a preference changes.

prefs.user_gesture_required_for_media_playback =

!google_util::IsGoogleSearchUrl(web_contents->GetLastCommittedURL());

host->UpdateWebkitPreferences(prefs);

« no previous file with comments | « android_webview/native/aw_settings.cc ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »