Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1951)

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 433733002: Revert 284592 "Cache the current WebPreferences on RenderViewHos..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2107/src/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_view_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_view_host_impl.cc (revision 286686)
+++ content/browser/renderer_host/render_view_host_impl.cc (working copy)
@@ -289,7 +289,7 @@
ViewMsg_New_Params params;
params.renderer_preferences =
delegate_->GetRendererPrefs(GetProcess()->GetBrowserContext());
- params.web_preferences = GetWebkitPreferences();
+ params.web_preferences = delegate_->GetWebkitPrefs();
params.view_id = GetRoutingID();
params.main_frame_routing_id = main_frame_routing_id_;
params.surface_id = surface_id();
@@ -329,7 +329,7 @@
GetProcess()->GetBrowserContext())));
}
-WebPreferences RenderViewHostImpl::ComputeWebkitPrefs(const GURL& url) {
+WebPreferences RenderViewHostImpl::GetWebkitPrefs(const GURL& url) {
TRACE_EVENT0("browser", "RenderViewHostImpl::GetWebkitPrefs");
WebPreferences prefs;
@@ -1418,10 +1418,7 @@
}
WebPreferences RenderViewHostImpl::GetWebkitPreferences() {
- if (!web_preferences_.get()) {
- OnWebkitPreferencesChanged();
- }
- return *web_preferences_;
+ return delegate_->GetWebkitPrefs();
}
void RenderViewHostImpl::DisownOpener() {
@@ -1432,14 +1429,9 @@
}
void RenderViewHostImpl::UpdateWebkitPreferences(const WebPreferences& prefs) {
- web_preferences_.reset(new WebPreferences(prefs));
Send(new ViewMsg_UpdateWebPreferences(GetRoutingID(), prefs));
}
-void RenderViewHostImpl::OnWebkitPreferencesChanged() {
- UpdateWebkitPreferences(delegate_->ComputeWebkitPrefs());
-}
-
void RenderViewHostImpl::GetAudioOutputControllers(
const GetAudioOutputControllersCallback& callback) const {
AudioRendererHost* audio_host =
« no previous file with comments | « content/browser/renderer_host/render_view_host_impl.h ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698