Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 433733002: Revert 284592 "Cache the current WebPreferences on RenderViewHos..." (Closed) Base URL: svn://svn.chromium.org/chrome/branches/2107/src/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/android/content_settings.cc ('k') | content/browser/frame_host/interstitial_page_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/browser_plugin/browser_plugin_guest.cc
===================================================================
--- content/browser/browser_plugin/browser_plugin_guest.cc (revision 286686)
+++ content/browser/browser_plugin/browser_plugin_guest.cc (working copy)
@@ -223,10 +223,7 @@
new BrowserPluginMsg_GuestContentWindowReady(instance_id_,
guest_routing_id));
- // TODO(chrishtr): this code is wrong. The navigate_on_drag_drop field will
- // be reset again the next time preferences are updated.
- WebPreferences prefs =
- GetWebContents()->GetRenderViewHost()->GetWebkitPreferences();
+ WebPreferences prefs = GetWebContents()->GetWebkitPrefs();
prefs.navigate_on_drag_drop = false;
GetWebContents()->GetRenderViewHost()->UpdateWebkitPreferences(prefs);
« no previous file with comments | « content/browser/android/content_settings.cc ('k') | content/browser/frame_host/interstitial_page_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698