Make PPAPI headers compile with C compilers (gcc on Linux & Mac and MSVS on W...

Make PPAPI headers compile with C compilers (gcc on Linux & Mac and MSVS on Windows).  This includes changing bool to PP_Bool and adding a PP_INLINE macro.

TEST=tests/test_c_includes.c
BUG=59791, 53451
The first patch set is a straight copy of http://codereview.chromium.org/4019010/show which got LGTMed when PPAPI was in its own repo, but had to be rolled back in order to include chrome changes.

IMPORTANT:  This change will break plugin implementations that use the C interface, and might break others as well.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=65200

[dmichael(do not use this one), 2010-11-04 18:47:53]

Sorry for the long reviewer list, I wanted to make sure anyone who commented on
4019010 had a chance to look at this.

My changes to chrome to adapt to PP_Bool.  For src/ppapi, this is almost
identical to:
http://codereview.chromium.org/4019010/show
Except merged with more recent changes and fixing a lint error.  Most of the
"new" changes are in webkit/glue/pepper_plugin.cc

Try bots are looking good so far:
http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@g...


Note:  This WILL break plugins based on the C API (like the NaCl plugin). 
Plugins using the cpp interface exclusively may be okay.

[brettw, 2010-11-04 20:07:51]

LGTM, just some style nits.

http://codereview.chromium.org/4310002/diff/140006/137023
File ppapi/c/dev/ppb_url_response_info_dev.h (right):

http://codereview.chromium.org/4310002/diff/140006/137023#newcode32
ppapi/c/dev/ppb_url_response_info_dev.h:32: PP_URLResponseProperty_Dev
property);
Can you fix this indenting so it matches the previous arg?

http://codereview.chromium.org/4310002/diff/140006/137026
File ppapi/c/dev/ppb_video_decoder_dev.h (right):

http://codereview.chromium.org/4310002/diff/140006/137026#newcode84
ppapi/c/dev/ppb_video_decoder_dev.h:84: PP_Bool
(*ReturnUncompressedDataBuffer)(PP_Resource decoder,
The PP_Resource should have been left on the next line. Generally the args
should be indented to the same place if possible.

http://codereview.chromium.org/4310002/diff/140006/137039
File ppapi/c/pp_rect.h (right):

http://codereview.chromium.org/4310002/diff/140006/137039#newcode27
ppapi/c/pp_rect.h:27: int32_t w, int32_t h) {
Fix indenting.

http://codereview.chromium.org/4310002/diff/140006/137049
File ppapi/cpp/common.h (right):

http://codereview.chromium.org/4310002/diff/140006/137049#newcode18
ppapi/cpp/common.h:18: namespace pp {
Make sure there's a blank line on both side of a namespace beginning.

http://codereview.chromium.org/4310002/diff/140006/137049#newcode28
ppapi/cpp/common.h:28: }  // namespace pp
Ditto for the endings.

http://codereview.chromium.org/4310002/diff/140006/137052
File ppapi/cpp/dev/find_dev.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137052#newcode26
ppapi/cpp/dev/find_dev.cc:26: bool return_value =
I probably would have indented this as so:
bool return_value = static_cast<Find_Dev*>(object)->StartFind(
    text, PPBoolToBool(case_sensitive));
(but what you have is legal if you like it better).

http://codereview.chromium.org/4310002/diff/140006/137052#newcode35
ppapi/cpp/dev/find_dev.cc:35: if (object) {
Don't add {} here.

http://codereview.chromium.org/4310002/diff/140006/137072
File ppapi/ppapi.gyp (right):

http://codereview.chromium.org/4310002/diff/140006/137072#newcode374
ppapi/ppapi.gyp:374: #    {
Got some end-of-line spaces in this section.

http://codereview.chromium.org/4310002/diff/140006/137074
File ppapi/tests/test_graphics_2d.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137074#newcode75
ppapi/tests/test_graphics_2d.cc:75: return (PP_TRUE == return_value);
You can use the C++ helper functions from this file.

http://codereview.chromium.org/4310002/diff/140006/137080
File webkit/glue/plugins/pepper_common.h (right):

http://codereview.chromium.org/4310002/diff/140006/137080#newcode21
webkit/glue/plugins/pepper_common.h:21: inline PP_Var BoolToVar(bool value) {
You don't use this, so I'd remove it. You have BoolToPPVar in the var file, but
that seems sufficient for it to be there to me.

http://codereview.chromium.org/4310002/diff/140006/137100
File webkit/glue/plugins/pepper_var.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137100#newcode461
webkit/glue/plugins/pepper_var.cc:461: if (result.type == PP_VARTYPE_BOOL) {
Don't add {} here.

[dmichael(do not use this one), 2010-11-04 21:06:26]

Thanks for the careful reading of the code, Brett.  Uploaded the requested
changes and kicked off another try run:

http://build.chromium.org/p/tryserver.chromium/waterfall?committer=dmichael@g...

http://codereview.chromium.org/4310002/diff/140006/137023
File ppapi/c/dev/ppb_url_response_info_dev.h (right):

http://codereview.chromium.org/4310002/diff/140006/137023#newcode32
ppapi/c/dev/ppb_url_response_info_dev.h:32: PP_URLResponseProperty_Dev
property);
On 2010/11/04 20:07:51, brettw wrote:
> Can you fix this indenting so it matches the previous arg?
Done.

http://codereview.chromium.org/4310002/diff/140006/137026
File ppapi/c/dev/ppb_video_decoder_dev.h (right):

http://codereview.chromium.org/4310002/diff/140006/137026#newcode84
ppapi/c/dev/ppb_video_decoder_dev.h:84: PP_Bool
(*ReturnUncompressedDataBuffer)(PP_Resource decoder,
On 2010/11/04 20:07:51, brettw wrote:
> The PP_Resource should have been left on the next line. Generally the args
> should be indented to the same place if possible.
Done.

http://codereview.chromium.org/4310002/diff/140006/137039
File ppapi/c/pp_rect.h (right):

http://codereview.chromium.org/4310002/diff/140006/137039#newcode27
ppapi/c/pp_rect.h:27: int32_t w, int32_t h) {
On 2010/11/04 20:07:51, brettw wrote:
> Fix indenting.
Done.

http://codereview.chromium.org/4310002/diff/140006/137049
File ppapi/cpp/common.h (right):

http://codereview.chromium.org/4310002/diff/140006/137049#newcode18
ppapi/cpp/common.h:18: namespace pp {
On 2010/11/04 20:07:51, brettw wrote:
> Make sure there's a blank line on both side of a namespace beginning.
Argh, I forgot it (again) when I patched ppapi in the new place.  Nice catch
(again).  Done.

http://codereview.chromium.org/4310002/diff/140006/137049#newcode28
ppapi/cpp/common.h:28: }  // namespace pp
On 2010/11/04 20:07:51, brettw wrote:
> Ditto for the endings.
Done.

http://codereview.chromium.org/4310002/diff/140006/137052
File ppapi/cpp/dev/find_dev.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137052#newcode26
ppapi/cpp/dev/find_dev.cc:26: bool return_value =
On 2010/11/04 20:07:51, brettw wrote:
> I probably would have indented this as so:
> bool return_value = static_cast<Find_Dev*>(object)->StartFind(
>     text, PPBoolToBool(case_sensitive));
> (but what you have is legal if you like it better).
When in Rome ;-).  Done.

http://codereview.chromium.org/4310002/diff/140006/137052#newcode35
ppapi/cpp/dev/find_dev.cc:35: if (object) {
On 2010/11/04 20:07:51, brettw wrote:
> Don't add {} here.
Ah, thanks.  I only meant to add them where statements grew to >1 line (just for
readability).  Just to be clear, I think this is okay per the style guide, but
your suggestion makes it more consistent with the rest of this file & directory.
 Done.

http://codereview.chromium.org/4310002/diff/140006/137072
File ppapi/ppapi.gyp (right):

http://codereview.chromium.org/4310002/diff/140006/137072#newcode374
ppapi/ppapi.gyp:374: #    {
On 2010/11/04 20:07:51, brettw wrote:
> Got some end-of-line spaces in this section.
Good catch!  Done.

http://codereview.chromium.org/4310002/diff/140006/137074
File ppapi/tests/test_graphics_2d.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137074#newcode75
ppapi/tests/test_graphics_2d.cc:75: return (PP_TRUE == return_value);
On 2010/11/04 20:07:51, brettw wrote:
> You can use the C++ helper functions from this file.
Done.

http://codereview.chromium.org/4310002/diff/140006/137080
File webkit/glue/plugins/pepper_common.h (right):

http://codereview.chromium.org/4310002/diff/140006/137080#newcode21
webkit/glue/plugins/pepper_common.h:21: inline PP_Var BoolToVar(bool value) {
On 2010/11/04 20:07:51, brettw wrote:
> You don't use this, so I'd remove it. You have BoolToPPVar in the var file,
but
> that seems sufficient for it to be there to me.
Yes, I agree.  I copied it in there for that reason and just forgot to delete it
from here.  Nice catch.

http://codereview.chromium.org/4310002/diff/140006/137100
File webkit/glue/plugins/pepper_var.cc (right):

http://codereview.chromium.org/4310002/diff/140006/137100#newcode461
webkit/glue/plugins/pepper_var.cc:461: if (result.type == PP_VARTYPE_BOOL) {
On 2010/11/04 20:07:51, brettw wrote:
> Don't add {} here.
Done.

[brettw, 2010-11-04 21:10:45]

Okay. (Since I already said LGTM, you don't have to wait to hear from me again.)

[dmichael(do not use this one), 2010-11-05 14:54:04]

Committed 65200.  Now to babysit the bots and make sure it goes through...