Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: ppapi/c/dev/ppb_url_request_info_dev.h

Issue 4310002: Make PPAPI headers compile with C compilers (gcc on Linux & Mac and MSVS on W... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/dev/ppb_url_loader_dev.h ('k') | ppapi/c/dev/ppb_url_response_info_dev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/dev/ppb_url_request_info_dev.h
===================================================================
--- ppapi/c/dev/ppb_url_request_info_dev.h (revision 65116)
+++ ppapi/c/dev/ppb_url_request_info_dev.h (working copy)
@@ -5,6 +5,7 @@
#ifndef PPAPI_C_DEV_PPB_URL_REQUEST_INFO_DEV_H_
#define PPAPI_C_DEV_PPB_URL_REQUEST_INFO_DEV_H_
+#include "ppapi/c/pp_bool.h"
#include "ppapi/c/pp_module.h"
#include "ppapi/c/pp_resource.h"
#include "ppapi/c/pp_stdint.h"
@@ -16,47 +17,50 @@
PP_URLREQUESTPROPERTY_URL, // string
PP_URLREQUESTPROPERTY_METHOD, // string
PP_URLREQUESTPROPERTY_HEADERS, // string, \n-delim
- PP_URLREQUESTPROPERTY_STREAMTOFILE, // bool (default=false)
- PP_URLREQUESTPROPERTY_FOLLOWREDIRECTS, // bool (default=true)
+ PP_URLREQUESTPROPERTY_STREAMTOFILE, // PP_Bool (default=PP_FALSE)
+ PP_URLREQUESTPROPERTY_FOLLOWREDIRECTS, // PP_Bool (default=PP_TRUE)
// Set to true if you want to be able to poll the download progress via the
// URLLoader.GetDownloadProgress function.
//
- // Boolean (default = false).
+ // Boolean (default = PP_FALSE).
PP_URLREQUESTPROPERTY_RECORDDOWNLOADPROGRESS,
// Set to true if you want to be able to pull the upload progress via the
// URLLoader.GetUploadProgress function.
//
- // Boolean (default = false).
+ // Boolean (default = PP_FALSE).
PP_URLREQUESTPROPERTY_RECORDUPLOADPROGRESS
// TODO(darin): Add security/privacy options?
} PP_URLRequestProperty_Dev;
-#define PPB_URLREQUESTINFO_DEV_INTERFACE "PPB_URLRequestInfo(Dev);0.1"
+#define PPB_URLREQUESTINFO_DEV_INTERFACE "PPB_URLRequestInfo(Dev);0.2"
struct PPB_URLRequestInfo_Dev {
// Create a new URLRequestInfo object. Returns 0 if the module is invalid.
PP_Resource (*Create)(PP_Module module);
- // Returns true if the given resource is an URLRequestInfo. Returns false if
- // the resource is invalid or some type other than an URLRequestInfo.
- bool (*IsURLRequestInfo)(PP_Resource resource);
+ // Returns PP_TRUE if the given resource is an URLRequestInfo. Returns
+ // PP_FALSE if the resource is invalid or some type other than an
+ // URLRequestInfo.
+ PP_Bool (*IsURLRequestInfo)(PP_Resource resource);
- // Sets a request property. Returns false if any of the parameters are
- // invalid. The value property must be the correct type according to the
- // property being set.
- bool (*SetProperty)(PP_Resource request,
- PP_URLRequestProperty_Dev property,
- struct PP_Var value);
+ // Sets a request property. Returns PP_FALSE if any of the parameters are
+ // invalid, PP_TRUE on success. The value property must be the correct type
+ // according to the property being set.
+ PP_Bool (*SetProperty)(PP_Resource request,
+ PP_URLRequestProperty_Dev property,
+ struct PP_Var value);
// Append data to the request body.
//
// A Content-Length request header will be automatically generated.
//
- // Returns false if any of the parameters are invalid.
- bool (*AppendDataToBody)(PP_Resource request, const char* data, uint32_t len);
+ // Returns PP_FALSE if any of the parameters are invalid, PP_TRUE on success.
+ PP_Bool (*AppendDataToBody)(PP_Resource request,
+ const char* data,
+ uint32_t len);
// Append a file reference to be uploaded.
//
@@ -72,12 +76,12 @@
//
// A Content-Length request header will be automatically generated.
//
- // Returns false if any of the parameters are invalid.
- bool (*AppendFileToBody)(PP_Resource request,
- PP_Resource file_ref,
- int64_t start_offset,
- int64_t number_of_bytes,
- PP_Time expected_last_modified_time);
+ // Returns PP_FALSE if any of the parameters are invalid, PP_TRUE on success.
+ PP_Bool (*AppendFileToBody)(PP_Resource request,
+ PP_Resource file_ref,
+ int64_t start_offset,
+ int64_t number_of_bytes,
+ PP_Time expected_last_modified_time);
};
#endif // PPAPI_C_DEV_PPB_URL_REQUEST_INFO_DEV_H_
« no previous file with comments | « ppapi/c/dev/ppb_url_loader_dev.h ('k') | ppapi/c/dev/ppb_url_response_info_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698