Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: ppapi/c/dev/ppb_graphics_3d_dev.h

Issue 4310002: Make PPAPI headers compile with C compilers (gcc on Linux & Mac and MSVS on W... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 10 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/c/dev/ppb_fullscreen_dev.h ('k') | ppapi/c/dev/ppb_scrollbar_dev.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/c/dev/ppb_graphics_3d_dev.h
===================================================================
--- ppapi/c/dev/ppb_graphics_3d_dev.h (revision 65116)
+++ ppapi/c/dev/ppb_graphics_3d_dev.h (working copy)
@@ -5,6 +5,7 @@
#ifndef PPAPI_C_DEV_PPB_GRAPHICS_3D_DEV_H_
#define PPAPI_C_DEV_PPB_GRAPHICS_3D_DEV_H_
+#include "ppapi/c/pp_bool.h"
#include "ppapi/c/pp_instance.h"
#include "ppapi/c/pp_module.h"
#include "ppapi/c/pp_resource.h"
@@ -24,7 +25,7 @@
// // Shutdown.
// core->ReleaseResource(context);
-#define PPB_GRAPHICS_3D_DEV_INTERFACE "PPB_Graphics3D(Dev);0.1"
+#define PPB_GRAPHICS_3D_DEV_INTERFACE "PPB_Graphics3D(Dev);0.2"
// These are the same error codes as used by EGL.
enum {
@@ -44,21 +45,21 @@
};
struct PPB_Graphics3D_Dev {
- bool (*IsGraphics3D)(PP_Resource resource);
+ PP_Bool (*IsGraphics3D)(PP_Resource resource);
// EGL-like configuration ----------------------------------------------------
- bool (*GetConfigs)(int32_t* configs,
- int32_t config_size,
- int32_t* num_config);
+ PP_Bool (*GetConfigs)(int32_t* configs,
+ int32_t config_size,
+ int32_t* num_config);
- bool (*ChooseConfig)(const int32_t* attrib_list,
- int32_t* configs,
- int32_t config_size,
- int32_t* num_config);
+ PP_Bool (*ChooseConfig)(const int32_t* attrib_list,
+ int32_t* configs,
+ int32_t config_size,
+ int32_t* num_config);
// TODO(apatrick): What to do if the browser window is moved to
// another display? Do the configs potentially change?
- bool (*GetConfigAttrib)(int32_t config, int32_t attribute, int32_t* value);
+ PP_Bool (*GetConfigAttrib)(int32_t config, int32_t attribute, int32_t* value);
const char* (*QueryString)(int32_t name);
// ---------------------------------------------------------------------------
@@ -77,8 +78,9 @@
// Any thread.
void* (*GetProcAddress)(const char* name);
- // Make a particular context current of the calling thread.
- bool (*MakeCurent)(PP_Resource context);
+ // Make a particular context current of the calling thread. Returns PP_TRUE
+ // on success, PP_FALSE on failure.
+ PP_Bool (*MakeCurent)(PP_Resource context);
// Returns the calling thread's current context or NULL if no context is
// current.
@@ -91,7 +93,7 @@
// better for correct alpha blending effect. Most existing OpenGL code assumes
// linear. I could convert from linear to premultiplied during the copy from
// back-buffer to offscreen "front-buffer".
- bool (*SwapBuffers)(PP_Resource context);
+ PP_Bool (*SwapBuffers)(PP_Resource context);
// Returns the current error for this thread. This is not associated with a
// particular context. It is distinct from the GL error returned by
@@ -100,4 +102,3 @@
};
#endif // PPAPI_C_DEV_PPB_GRAPHICS_3D_DEV_H_
-
« no previous file with comments | « ppapi/c/dev/ppb_fullscreen_dev.h ('k') | ppapi/c/dev/ppb_scrollbar_dev.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698