Issue 429543004: Only generate a single normal IC per kind per slow-mode map.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 429543004: Only generate a single normal IC per kind per slow-mode map. (Closed)

Created:
6 years, 4 months ago by Toon Verwaest

Modified:
6 years, 4 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Only generate a single normal IC per kind per slow-mode map. BUG= R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22680

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+60 lines, -42 lines)			Patch
M	include/v8.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/arm64/stub-cache-arm64.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	src/heap.h	View		4 chunks	+16 lines, -28 lines	0 comments	Download
M	src/heap.cc	View		1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View		1 chunk	+8 lines, -2 lines	0 comments	Download
M	src/ic.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/stub-cache.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1	1 chunk	+8 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Jakob Kummerow

LGTM. Consider "porting" the comment to the other platforms too.

6 years, 4 months ago (2014-07-29 17:00:48 UTC) #2

Toon Verwaest

6 years, 4 months ago (2014-07-29 17:03:01 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22680 (presubmit successful).