Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: src/arm64/stub-cache-arm64.cc

Issue 429543004: Only generate a single normal IC per kind per slow-mode map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM64 7 #if V8_TARGET_ARCH_ARM64
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1223 matching lines...) Expand 10 before | Expand all | Expand 10 after
1234 1234
1235 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types, 1235 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
1236 CodeHandleList* handlers, 1236 CodeHandleList* handlers,
1237 Handle<Name> name, 1237 Handle<Name> name,
1238 Code::StubType type, 1238 Code::StubType type,
1239 IcCheckType check) { 1239 IcCheckType check) {
1240 Label miss; 1240 Label miss;
1241 1241
1242 if (check == PROPERTY && 1242 if (check == PROPERTY &&
1243 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 1243 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
1244 __ CompareAndBranch(this->name(), Operand(name), ne, &miss); 1244 // In case we are compiling an IC for dictionary loads and stores, just
1245 // check whether the name is unique.
1246 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
1247 __ JumpIfNotUniqueName(this->name(), &miss);
1248 } else {
1249 __ CompareAndBranch(this->name(), Operand(name), ne, &miss);
1250 }
1245 } 1251 }
1246 1252
1247 Label number_case; 1253 Label number_case;
1248 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 1254 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
1249 __ JumpIfSmi(receiver(), smi_target); 1255 __ JumpIfSmi(receiver(), smi_target);
1250 1256
1251 // Polymorphic keyed stores may use the map register 1257 // Polymorphic keyed stores may use the map register
1252 Register map_reg = scratch1(); 1258 Register map_reg = scratch1();
1253 ASSERT(kind() != Code::KEYED_STORE_IC || 1259 ASSERT(kind() != Code::KEYED_STORE_IC ||
1254 map_reg.is(KeyedStoreIC::MapRegister())); 1260 map_reg.is(KeyedStoreIC::MapRegister()));
(...skipping 97 matching lines...) Expand 10 before | Expand all | Expand 10 after
1352 1358
1353 // Miss case, call the runtime. 1359 // Miss case, call the runtime.
1354 __ Bind(&miss); 1360 __ Bind(&miss);
1355 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1361 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1356 } 1362 }
1357 1363
1358 1364
1359 } } // namespace v8::internal 1365 } } // namespace v8::internal
1360 1366
1361 #endif // V8_TARGET_ARCH_ARM64 1367 #endif // V8_TARGET_ARCH_ARM64
OLDNEW
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698