Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 429543004: Only generate a single normal IC per kind per slow-mode map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « include/v8.h ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1255 matching lines...) Expand 10 before | Expand all | Expand 10 after
1266 1266
1267 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types, 1267 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
1268 CodeHandleList* handlers, 1268 CodeHandleList* handlers,
1269 Handle<Name> name, 1269 Handle<Name> name,
1270 Code::StubType type, 1270 Code::StubType type,
1271 IcCheckType check) { 1271 IcCheckType check) {
1272 Label miss; 1272 Label miss;
1273 1273
1274 if (check == PROPERTY && 1274 if (check == PROPERTY &&
1275 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 1275 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
1276 __ cmp(this->name(), Operand(name)); 1276 // In case we are compiling an IC for dictionary loads and stores, just
1277 __ b(ne, &miss); 1277 // check whether the name is unique.
1278 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
1279 __ JumpIfNotUniqueName(this->name(), &miss);
1280 } else {
1281 __ cmp(this->name(), Operand(name));
1282 __ b(ne, &miss);
1283 }
1278 } 1284 }
1279 1285
1280 Label number_case; 1286 Label number_case;
1281 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 1287 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
1282 __ JumpIfSmi(receiver(), smi_target); 1288 __ JumpIfSmi(receiver(), smi_target);
1283 1289
1284 // Polymorphic keyed stores may use the map register 1290 // Polymorphic keyed stores may use the map register
1285 Register map_reg = scratch1(); 1291 Register map_reg = scratch1();
1286 ASSERT(kind() != Code::KEYED_STORE_IC || 1292 ASSERT(kind() != Code::KEYED_STORE_IC ||
1287 map_reg.is(KeyedStoreIC::MapRegister())); 1293 map_reg.is(KeyedStoreIC::MapRegister()));
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
1387 1393
1388 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1394 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1389 } 1395 }
1390 1396
1391 1397
1392 #undef __ 1398 #undef __
1393 1399
1394 } } // namespace v8::internal 1400 } } // namespace v8::internal
1395 1401
1396 #endif // V8_TARGET_ARCH_ARM 1402 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « include/v8.h ('k') | src/arm64/stub-cache-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698