Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 429543004: Only generate a single normal IC per kind per slow-mode map. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Port comment Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 1282 matching lines...) Expand 10 before | Expand all | Expand 10 after
1293 1293
1294 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types, 1294 Handle<Code> PropertyICCompiler::CompilePolymorphic(TypeHandleList* types,
1295 CodeHandleList* handlers, 1295 CodeHandleList* handlers,
1296 Handle<Name> name, 1296 Handle<Name> name,
1297 Code::StubType type, 1297 Code::StubType type,
1298 IcCheckType check) { 1298 IcCheckType check) {
1299 Label miss; 1299 Label miss;
1300 1300
1301 if (check == PROPERTY && 1301 if (check == PROPERTY &&
1302 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) { 1302 (kind() == Code::KEYED_LOAD_IC || kind() == Code::KEYED_STORE_IC)) {
1303 __ cmp(this->name(), Immediate(name)); 1303 // In case we are compiling an IC for dictionary loads and stores, just
1304 __ j(not_equal, &miss); 1304 // check whether the name is unique.
1305 if (name.is_identical_to(isolate()->factory()->normal_ic_symbol())) {
1306 __ JumpIfNotUniqueName(this->name(), &miss);
1307 } else {
1308 __ cmp(this->name(), Immediate(name));
1309 __ j(not_equal, &miss);
1310 }
1305 } 1311 }
1306 1312
1307 Label number_case; 1313 Label number_case;
1308 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss; 1314 Label* smi_target = IncludesNumberType(types) ? &number_case : &miss;
1309 __ JumpIfSmi(receiver(), smi_target); 1315 __ JumpIfSmi(receiver(), smi_target);
1310 1316
1311 // Polymorphic keyed stores may use the map register 1317 // Polymorphic keyed stores may use the map register
1312 Register map_reg = scratch1(); 1318 Register map_reg = scratch1();
1313 ASSERT(kind() != Code::KEYED_STORE_IC || 1319 ASSERT(kind() != Code::KEYED_STORE_IC ||
1314 map_reg.is(KeyedStoreIC::MapRegister())); 1320 map_reg.is(KeyedStoreIC::MapRegister()));
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
1388 // ----------------------------------- 1394 // -----------------------------------
1389 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1395 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1390 } 1396 }
1391 1397
1392 1398
1393 #undef __ 1399 #undef __
1394 1400
1395 } } // namespace v8::internal 1401 } } // namespace v8::internal
1396 1402
1397 #endif // V8_TARGET_ARCH_IA32 1403 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698