Issue 426613002: Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSoc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 426613002: Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSoc… (Closed)

Created:
6 years, 4 months ago by Anders Johnsen

Modified:
6 years, 4 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSocket.bind'. Note that I have not been able to reproduce the error, thus no test is added for this case. BUG=http://code.google.com/p/dart/issues/detail?id=19815 R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=38606

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -16 lines)			Patch
M	runtime/bin/eventhandler_win.cc	View	2 chunks	+2 lines, -12 lines	0 comments	Download
M	runtime/bin/main.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/bin/socket.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/socket.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_android.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_macos.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View	1 chunk	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

6 years, 4 months ago (2014-07-28 11:37:04 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r38606 (presubmit successful).

Expand Messages | Collapse Messages