Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: runtime/bin/eventhandler_win.cc

Issue 426613002: Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSoc… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_win.cc
diff --git a/runtime/bin/eventhandler_win.cc b/runtime/bin/eventhandler_win.cc
index a67e2497339de726e88c62c0b36c450248d2c749..cc42e62baf350b70a92d39ae045c7beac8f7a095 100644
--- a/runtime/bin/eventhandler_win.cc
+++ b/runtime/bin/eventhandler_win.cc
@@ -578,10 +578,8 @@ ClientSocket* ListenSocket::Accept() {
if (accepted_head_ == NULL) accepted_tail_ = NULL;
result->set_next(NULL);
if (!IsClosing()) {
- while (pending_accept_count() < 5) {
- if (!IssueAccept()) {
- HandleError(this);
- }
+ if (!IssueAccept()) {
+ HandleError(this);
}
}
return result;
@@ -1040,14 +1038,6 @@ void EventHandlerImplementation::HandleInterrupt(InterruptMessage* msg) {
handle->set_mask(handle->mask() & ~event_mask);
DartUtils::PostInt32(handle->port(), event_mask);
}
- // Always keep 5 outstanding accepts going, to enhance performance.
- while (listen_socket->pending_accept_count() < 5) {
- bool accept_success = listen_socket->IssueAccept();
- if (!accept_success) {
- HandleError(listen_socket);
- break;
- }
- }
}
} else {
handle->EnsureInitialized(this);
« no previous file with comments | « no previous file | runtime/bin/main.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698