runtime/bin/socket.cc - Issue 426613002: Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSoc…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/socket.cc

Issue 426613002: Start accepting incoming sockets earlier on Windows, to associate a at AcceptEx error to 'ServerSoc… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/socket.cc

diff --git a/runtime/bin/socket.cc b/runtime/bin/socket.cc

index 1b619517cececd22147bb312f367fb6a684b5855..a22930ee7ca63f8ad92e77057caf676177c9f2bb 100644

--- a/runtime/bin/socket.cc

+++ b/runtime/bin/socket.cc

@@ -378,7 +378,7 @@ void FUNCTION_NAME(ServerSocket_CreateBindListen)(Dart_NativeArguments args) {

intptr_t socket = ServerSocket::CreateBindListen(

addr, port, backlog, v6_only);

OSError error;

- if (socket >= 0) {

+ if (socket >= 0 && ServerSocket::StartAccept(socket)) {

Socket::SetSocketIdNativeField(Dart_GetNativeArgument(args, 0), socket);

Dart_SetReturnValue(args, Dart_True());

} else {

« no previous file with comments | « runtime/bin/socket.h ('k') | runtime/bin/socket_android.cc » ('j') | no next file with comments »