Simplify SVGAnimat\w+Element::parseAttribute

Simplify SVGAnimat\w+Element::parseAttribute

- |SVGAnimate{Motion,Transform}Element::isSupportedAttribute| is only
called from |SVGAnimate{Motion,Transform}Element::parseAttribute|. Inlined.

BUG=397902
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179118

[kouhei (in TOK), 2014-07-28 13:34:41]

Would you take a look?

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (left):

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:213: return;
This is handled by SVGElement::parseAttributeNew

[fs, 2014-07-28 14:01:02]

LGTM w/ potential nit.

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:216: if (!isSupportedAttribute(attrName)
&& !SVGTests::isKnownAttribute(attrName)) {
Nit: Maybe make a note that this (the SVGTests-call) should/will be moved back
to isSupportedAttribute - if that's the intention that is... maybe it isn't?

[kouhei (in TOK), 2014-07-28 14:28:58]

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:216: if (!isSupportedAttribute(attrName)
&& !SVGTests::isKnownAttribute(attrName)) {
On 2014/07/28 14:01:01, fs wrote:
> Nit: Maybe make a note that this (the SVGTests-call) should/will be moved back
> to isSupportedAttribute - if that's the intention that is... maybe it isn't?

Hmm, I didn't intend to move it back later. Maybe I don't understand intention
of isSupportedAttribute() well.

For this particular CL, I guess the right fix is to derive SVGTests in
SVGSMILElement. In that way here is more natural, and SVGDiscardElement will get
SVGTests support too.

SVGDiscardElement should support SVGTests attributes but currently it doesn't.
https://svgwg.org/svg2-draft/single-page.html#struct-DiscardElement

[fs, 2014-07-28 17:12:37]

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
File Source/core/svg/SVGAnimationElement.cpp (right):

https://codereview.chromium.org/424733002/diff/40001/Source/core/svg/SVGAnima...
Source/core/svg/SVGAnimationElement.cpp:216: if (!isSupportedAttribute(attrName)
&& !SVGTests::isKnownAttribute(attrName)) {
On 2014/07/28 14:28:58, kouhei wrote:
> On 2014/07/28 14:01:01, fs wrote:
> > Nit: Maybe make a note that this (the SVGTests-call) should/will be moved
back
> > to isSupportedAttribute - if that's the intention that is... maybe it isn't?
> 
> Hmm, I didn't intend to move it back later. Maybe I don't understand intention
> of isSupportedAttribute() well.
> 
> For this particular CL, I guess the right fix is to derive SVGTests in
> SVGSMILElement. In that way here is more natural, and SVGDiscardElement will
get
> SVGTests support too.

Moving it to SVGSMILElement SGTM (and would void this comment/confusion).

[kouhei (in TOK), 2014-07-29 09:08:24]

The CQ bit was checked by kouhei@chromium.org

[commit-bot: I haz the power, 2014-07-29 09:09:25]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kouhei@chromium.org/424733002/60001

[commit-bot: I haz the power, 2014-07-29 10:19:03]

Change committed as 179118