Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1644)

Unified Diff: Source/core/svg/SVGAnimateTransformElement.cpp

Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimateTransformElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimateTransformElement.cpp
diff --git a/Source/core/svg/SVGAnimateTransformElement.cpp b/Source/core/svg/SVGAnimateTransformElement.cpp
index d8d7644694051a236067a0fff04fb48f7bfce008..492cf72973448bc2e3db4387d9456e04f0a468ad 100644
--- a/Source/core/svg/SVGAnimateTransformElement.cpp
+++ b/Source/core/svg/SVGAnimateTransformElement.cpp
@@ -50,21 +50,8 @@ bool SVGAnimateTransformElement::hasValidAttributeType()
return animatedPropertyType() == AnimatedTransformList;
}
-bool SVGAnimateTransformElement::isSupportedAttribute(const QualifiedName& attrName)
-{
- DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
- if (supportedAttributes.isEmpty())
- supportedAttributes.add(SVGNames::typeAttr);
- return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
-}
-
void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
{
- if (!isSupportedAttribute(name)) {
- SVGAnimateElement::parseAttribute(name, value);
- return;
- }
-
if (name == SVGNames::typeAttr) {
m_type = parseTransformType(value);
if (m_type == SVG_TRANSFORM_MATRIX)
@@ -72,7 +59,7 @@ void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const
return;
}
- ASSERT_NOT_REACHED();
+ SVGAnimateElement::parseAttribute(name, value);
}
}
« no previous file with comments | « Source/core/svg/SVGAnimateTransformElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698