Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Side by Side Diff: Source/core/svg/SVGAnimateTransformElement.cpp

Issue 424733002: Simplify SVGAnimat\w+Element::parseAttribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebased Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/svg/SVGAnimateTransformElement.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org> 2 * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org> 3 * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2008 Apple Inc. All rights reserved. 5 * Copyright (C) 2008 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 SVGElement* targetElement = this->targetElement(); 43 SVGElement* targetElement = this->targetElement();
44 if (!targetElement) 44 if (!targetElement)
45 return false; 45 return false;
46 46
47 if (attributeType() == AttributeTypeCSS) 47 if (attributeType() == AttributeTypeCSS)
48 return false; 48 return false;
49 49
50 return animatedPropertyType() == AnimatedTransformList; 50 return animatedPropertyType() == AnimatedTransformList;
51 } 51 }
52 52
53 bool SVGAnimateTransformElement::isSupportedAttribute(const QualifiedName& attrN ame)
54 {
55 DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
56 if (supportedAttributes.isEmpty())
57 supportedAttributes.add(SVGNames::typeAttr);
58 return supportedAttributes.contains<SVGAttributeHashTranslator>(attrName);
59 }
60
61 void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const AtomicString& value) 53 void SVGAnimateTransformElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
62 { 54 {
63 if (!isSupportedAttribute(name)) {
64 SVGAnimateElement::parseAttribute(name, value);
65 return;
66 }
67
68 if (name == SVGNames::typeAttr) { 55 if (name == SVGNames::typeAttr) {
69 m_type = parseTransformType(value); 56 m_type = parseTransformType(value);
70 if (m_type == SVG_TRANSFORM_MATRIX) 57 if (m_type == SVG_TRANSFORM_MATRIX)
71 m_type = SVG_TRANSFORM_UNKNOWN; 58 m_type = SVG_TRANSFORM_UNKNOWN;
72 return; 59 return;
73 } 60 }
74 61
75 ASSERT_NOT_REACHED(); 62 SVGAnimateElement::parseAttribute(name, value);
76 } 63 }
77 64
78 } 65 }
OLDNEW
« no previous file with comments | « Source/core/svg/SVGAnimateTransformElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698