Simplify SVGAnimat\w+Element::parseAttribute

Source/core/svg/SVGAnimationElement.cpp

 /*
  * Copyright (C) 2004, 2005 Nikolas Zimmermann <zimmermann@kde.org>
  * Copyright (C) 2004, 2005, 2006, 2007 Rob Buis <buis@kde.org>
  * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Cameron McCormack <cam@mcc.id.au>
  * Copyright (C) Research In Motion Limited 2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 124 matching lines @@
     if (string.is8Bit())
         parseKeySplinesInternal<LChar>(string, result);
     else
         parseKeySplinesInternal<UChar>(string, result);
 }
 
 bool SVGAnimationElement::isSupportedAttribute(const QualifiedName& attrName)
 {
     DEFINE_STATIC_LOCAL(HashSet<QualifiedName>, supportedAttributes, ());
     if (supportedAttributes.isEmpty()) {
-        SVGTests::addSupportedAttributes(supportedAttributes);
         supportedAttributes.add(SVGNames::valuesAttr);
         supportedAttributes.add(SVGNames::keyTimesAttr);
         supportedAttributes.add(SVGNames::keyPointsAttr);
         supportedAttributes.add(SVGNames::keySplinesAttr);
         supportedAttributes.add(SVGNames::attributeTypeAttr);
         supportedAttributes.add(SVGNames::calcModeAttr);
         supportedAttributes.add(SVGNames::fromAttr);
         supportedAttributes.add(SVGNames::toAttr);
         supportedAttributes.add(SVGNames::byAttr);
     }
@@ skipping 46 matching lines @@
     if (name == SVGNames::calcModeAttr) {
         setCalcMode(value);
         return;
     }
 
     if (name == SVGNames::fromAttr || name == SVGNames::toAttr || name == SVGNames::byAttr) {
         updateAnimationMode();
         return;
     }
 
-    if (SVGTests::parseAttribute(name, value))
-        return;

[kouhei (in TOK), 2014/07/28 13:34:41]

This is handled by SVGElement::parseAttributeNew

-
     ASSERT_NOT_REACHED();
 }
 
 void SVGAnimationElement::svgAttributeChanged(const QualifiedName& attrName)
 {
-    if (!isSupportedAttribute(attrName)) {
+    if (!isSupportedAttribute(attrName) && !SVGTests::isKnownAttribute(attrName)) {

[fs, 2014/07/28 14:01:01]

Nit: Maybe make a note that this (the SVGTests-call) should/will be moved back
to isSupportedAttribute - if that's the intention that is... maybe it isn't?

[kouhei (in TOK), 2014/07/28 14:28:58]

Hmm, I didn't intend to move it back later. Maybe I don't understand intention
of isSupportedAttribute() well.

For this particular CL, I guess the right fix is to derive SVGTests in
SVGSMILElement. In that way here is more natural, and SVGDiscardElement will get
SVGTests support too.

SVGDiscardElement should support SVGTests attributes but currently it doesn't.
https://svgwg.org/svg2-draft/single-page.html#struct-DiscardElement

[fs, 2014/07/28 17:12:36]

Moving it to SVGSMILElement SGTM (and would void this comment/confusion).

         SVGSMILElement::svgAttributeChanged(attrName);
         return;
     }
 
     animationAttributeChanged();
 }
 
 void SVGAnimationElement::animationAttributeChanged()
 {
     // Assumptions may not hold after an attribute change.
@@ skipping 455 matching lines @@
     SVGSMILElement::setAttributeName(attributeName);
     checkInvalidCSSAttributeType(targetElement());
 }
 
 void SVGAnimationElement::checkInvalidCSSAttributeType(SVGElement* target)
 {
     m_hasInvalidCSSAttributeType = target && hasValidAttributeName() && attributeType() == AttributeTypeCSS && !isTargetAttributeCSSProperty(target, attributeName());
 }
 
 }