Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 422023006: Add query for block dimensions of a given format (Closed)

Created:
6 years, 4 months ago by krajcevski
Modified:
6 years, 4 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add query for block dimensions of a given format Committed: https://skia.googlesource.com/skia/+/25a67bcb7ac70d3077e91126c4b8924a53557a38

Patch Set 1 #

Patch Set 2 : Turn off compression #

Total comments: 16

Patch Set 3 : Code review changes #

Total comments: 2

Patch Set 4 : Bracketing ifdefs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -16 lines) Patch
M src/gpu/GrSWMaskHelper.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrSWMaskHelper.cpp View 1 2 4 chunks +31 lines, -10 lines 0 comments Download
M src/opts/SkTextureCompression_opts.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/opts/SkTextureCompression_opts_arm.cpp View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M src/opts/SkTextureCompression_opts_none.cpp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/utils/SkTextureCompressor.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/utils/SkTextureCompressor.cpp View 2 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
krajcevski
6 years, 4 months ago (2014-07-29 15:51:12 UTC) #1
robertphillips
https://codereview.chromium.org/422023006/diff/20001/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/422023006/diff/20001/src/gpu/GrSWMaskHelper.cpp#newcode38 src/gpu/GrSWMaskHelper.cpp:38: static ? https://codereview.chromium.org/422023006/diff/20001/src/gpu/GrSWMaskHelper.cpp#newcode45 src/gpu/GrSWMaskHelper.cpp:45: Seems like there should be ...
6 years, 4 months ago (2014-07-29 16:16:04 UTC) #2
krajcevski
https://codereview.chromium.org/422023006/diff/20001/src/gpu/GrSWMaskHelper.cpp File src/gpu/GrSWMaskHelper.cpp (right): https://codereview.chromium.org/422023006/diff/20001/src/gpu/GrSWMaskHelper.cpp#newcode38 src/gpu/GrSWMaskHelper.cpp:38: On 2014/07/29 16:16:03, robertphillips wrote: > static ? Done. ...
6 years, 4 months ago (2014-07-29 17:49:51 UTC) #3
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 17:50:02 UTC) #4
krajcevski
The CQ bit was unchecked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 17:50:03 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/422023006/diff/40001/src/gpu/GrSWMaskHelper.h File src/gpu/GrSWMaskHelper.h (right): https://codereview.chromium.org/422023006/diff/40001/src/gpu/GrSWMaskHelper.h#newcode103 src/gpu/GrSWMaskHelper.h:103: SkRasterClip fRasterClip; #if GR_COMPRESS_ALPHA_MASK ?
6 years, 4 months ago (2014-07-29 17:53:37 UTC) #6
krajcevski
https://codereview.chromium.org/422023006/diff/40001/src/gpu/GrSWMaskHelper.h File src/gpu/GrSWMaskHelper.h (right): https://codereview.chromium.org/422023006/diff/40001/src/gpu/GrSWMaskHelper.h#newcode103 src/gpu/GrSWMaskHelper.h:103: SkRasterClip fRasterClip; On 2014/07/29 17:53:36, robertphillips wrote: > #if ...
6 years, 4 months ago (2014-07-29 17:59:35 UTC) #7
krajcevski
The CQ bit was checked by krajcevski@google.com
6 years, 4 months ago (2014-07-29 17:59:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/krajcevski@google.com/422023006/60001
6 years, 4 months ago (2014-07-29 17:59:52 UTC) #9
commit-bot: I haz the power
6 years, 4 months ago (2014-07-29 18:44:31 UTC) #10
Message was sent while issue was closed. 
Change committed as 25a67bcb7ac70d3077e91126c4b8924a53557a38

Powered by Google App Engine
This is Rietveld 408576698