Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 420603009: Revert 178910 "Revert 178850 "DevTools: Introduce createRawLocat..." (Closed)

Created:
6 years, 5 months ago by dgozman
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 178910 "Revert 178850 "DevTools: Introduce createRawLocat..." Broken test is incorrect and was disabled. > Revert 178850 "DevTools: Introduce createRawLocationByConsoleCal..." > > This CL or r178848 broke the following browser tests. > http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288 > > Let me revert the two CLs at the moment. > > > DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correctly. > > > > Links to internal VM scripts were not linkified correctly in Network panel popover. > > To test this, send an XHR from console, and try to jump to an injected script from Network popover. > > > > R=eustas, vsevik > > > > Review URL: https://codereview.chromium.org/412183002 > > TBR=aandrey@chromium.org > > Review URL: https://codereview.chromium.org/421523002 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M trunk/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -4 lines 0 comments Download
M trunk/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +2 lines, -1 line 0 comments Download
M trunk/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
dgozman
6 years, 5 months ago (2014-07-25 12:56:31 UTC) #1
dgozman
Committed patchset #1 manually as r178931.
6 years, 5 months ago (2014-07-25 12:57:53 UTC) #2
haraken
6 years, 5 months ago (2014-07-25 13:00:48 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698