Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: trunk/Source/devtools/front_end/console/ConsoleViewMessage.js

Issue 420603009: Revert 178910 "Revert 178850 "DevTools: Introduce createRawLocat..." (Closed) Base URL: svn://svn.chromium.org/blink/
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/Source/devtools/front_end/console/ConsoleViewMessage.js
===================================================================
--- trunk/Source/devtools/front_end/console/ConsoleViewMessage.js (revision 178930)
+++ trunk/Source/devtools/front_end/console/ConsoleViewMessage.js (working copy)
@@ -279,10 +279,7 @@
var target = this._target();
if (!this._linkifier || !target)
return null;
- // FIXME(62725): stack trace line/column numbers are one-based.
- var lineNumber = callFrame.lineNumber ? callFrame.lineNumber - 1 : 0;
- var columnNumber = callFrame.columnNumber ? callFrame.columnNumber - 1 : 0;
- var rawLocation = new WebInspector.DebuggerModel.Location(target, callFrame.scriptId, lineNumber, columnNumber);
+ var rawLocation = this._target().debuggerModel.createRawLocationByConsoleCallFrame(callFrame);
return this._linkifier.linkifyRawLocation(rawLocation, "console-message-url");
},
« no previous file with comments | « no previous file | trunk/Source/devtools/front_end/network/NetworkPanel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698