Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 412183002: DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correct… (Closed)

Created:
6 years, 5 months ago by aandrey
Modified:
6 years, 5 months ago
Reviewers:
eustas, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correctly. Links to internal VM scripts were not linkified correctly in Network panel popover. To test this, send an XHR from console, and try to jump to an injected script from Network popover. R=eustas, vsevik Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178850

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +1 line, -4 lines 0 comments Download
M Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +2 lines, -1 line 1 comment Download
M Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
aandrey
6 years, 5 months ago (2014-07-24 12:38:58 UTC) #1
eustas
lgtm https://codereview.chromium.org/412183002/diff/1/Source/devtools/front_end/network/NetworkPanel.js File Source/devtools/front_end/network/NetworkPanel.js (right): https://codereview.chromium.org/412183002/diff/1/Source/devtools/front_end/network/NetworkPanel.js#newcode1023 Source/devtools/front_end/network/NetworkPanel.js:1023: row.createChild("td").appendChild(this._linkifier.linkifyRawLocation(rawLocation)); Please, make sure this won't interfere with ...
6 years, 5 months ago (2014-07-24 13:51:45 UTC) #2
aandrey
The CQ bit was checked by aandrey@chromium.org
6 years, 5 months ago (2014-07-24 13:52:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aandrey@chromium.org/412183002/1
6 years, 5 months ago (2014-07-24 13:53:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_blink_rel on tryserver.blink ...
6 years, 5 months ago (2014-07-24 15:01:44 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 16:13:03 UTC) #6
Message was sent while issue was closed.
Change committed as 178850

Powered by Google App Engine
This is Rietveld 408576698