Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 421523002: Revert 178850 "DevTools: Introduce createRawLocationByConsoleCal..." (Closed)

Created:
6 years, 5 months ago by haraken
Modified:
6 years, 5 months ago
Reviewers:
aandrey
CC:
blink-reviews
Visibility:
Public.

Description

Revert 178850 "DevTools: Introduce createRawLocationByConsoleCal..." This CL or r178848 broke the following browser tests. http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3288 Let me revert the two CLs at the moment. > DevTools: Introduce createRawLocationByConsoleCallFrame to linkify links in Network popover correctly. > > Links to internal VM scripts were not linkified correctly in Network panel popover. > To test this, send an XHR from console, and try to jump to an injected script from Network popover. > > R=eustas, vsevik > > Review URL: https://codereview.chromium.org/412183002 TBR=aandrey@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178910

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M trunk/Source/devtools/front_end/console/ConsoleViewMessage.js View 1 chunk +4 lines, -1 line 0 comments Download
M trunk/Source/devtools/front_end/network/NetworkPanel.js View 1 chunk +1 line, -2 lines 0 comments Download
M trunk/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haraken
6 years, 5 months ago (2014-07-25 08:34:46 UTC) #1
haraken
Committed patchset #1 manually as r178910.
6 years, 5 months ago (2014-07-25 08:35:00 UTC) #2
aandrey
So, is this patch at fault? I cannot imagine how it is possible.
6 years, 5 months ago (2014-07-25 13:57:56 UTC) #3
haraken
On 2014/07/25 13:57:56, aandrey wrote: > So, is this patch at fault? I cannot imagine ...
6 years, 5 months ago (2014-07-25 15:27:03 UTC) #4
aandrey
6 years, 5 months ago (2014-07-25 15:38:00 UTC) #5
Message was sent while issue was closed.
On 2014/07/25 15:27:03, haraken wrote:
> On 2014/07/25 13:57:56, aandrey wrote:
> > So, is this patch at fault? I cannot imagine how it is possible.
> 
> Reverting r178848 and r178850 fixed the test failure, and I rolled Blink.
> 
> After that, dgozman@ noticed that the test is broken. dgozman@ disabled the
test
> and relanded both r178848 and r178850. (I don't know what the failure was.)

Yeah, thanks!

Powered by Google App Engine
This is Rietveld 408576698