Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method (Closed)

Created:
6 years, 4 months ago by ramant (doing other things)
Modified:
6 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@visitor_for_tracegraf_71863508
Project:
chromium
Visibility:
Public.

Description

Change ReliableQuicStream::OnStreamFrame to return void since the method already closes the connection when there are errors and callers are not checking the return value Make QuicStreamSequencer::OnStreamFrame return void instead of bool since it is already closing the connect or resetting the stream when there is an error. Make two QUIC methods return void instead of bool. Merge internal change: 71870242 R=rch@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -50 lines) Patch
M net/quic/quic_stream_sequencer.h View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_stream_sequencer.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M net/quic/quic_stream_sequencer_test.cc View 14 chunks +26 lines, -26 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +2 lines, -3 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/reliable_quic_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_spdy_client_stream_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ramant (doing other things)
6 years, 4 months ago (2014-07-29 00:51:59 UTC) #1
Ryan Hamilton
6 years, 4 months ago (2014-07-29 19:16:56 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698