net/quic/reliable_quic_stream.h - Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream.h

Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@visitor_for_tracegraf_71863508

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/reliable_quic_stream.h

diff --git a/net/quic/reliable_quic_stream.h b/net/quic/reliable_quic_stream.h

index 84eedec18a87b487d424c54cffab08e457fe9cdd..b9aa8ee732c9dc955210ed1fb9936c5ea24dc81c 100644

--- a/net/quic/reliable_quic_stream.h

+++ b/net/quic/reliable_quic_stream.h

@@ -38,9 +38,8 @@ class NET_EXPORT_PRIVATE ReliableQuicStream {

virtual ~ReliableQuicStream();

// Called when a (potentially duplicate) stream frame has been received

- // for this stream. Returns false if this frame can not be accepted

- // because there is too much data already buffered.

- virtual bool OnStreamFrame(const QuicStreamFrame& frame);

+ // for this stream.

+ virtual void OnStreamFrame(const QuicStreamFrame& frame);

// Called when the connection becomes writeable to allow the stream

// to write any pending data.

« no previous file with comments | « net/quic/quic_stream_sequencer_test.cc ('k') | net/quic/reliable_quic_stream.cc » ('j') | no next file with comments »