net/quic/reliable_quic_stream_test.cc - Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/reliable_quic_stream_test.cc

Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@visitor_for_tracegraf_71863508

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/quic/reliable_quic_stream_test.cc

diff --git a/net/quic/reliable_quic_stream_test.cc b/net/quic/reliable_quic_stream_test.cc

index 168677b8fc6f2bb96b9606b0fca9727aca00ddb5..f25011d5d307a6e2d1514338eaf64f542721e030 100644

--- a/net/quic/reliable_quic_stream_test.cc

+++ b/net/quic/reliable_quic_stream_test.cc

@@ -650,7 +650,7 @@ TEST_F(ReliableQuicStreamTest,

// Stream should not accept the frame, and the connection should be closed.

EXPECT_CALL(*connection_,

SendConnectionClose(QUIC_FLOW_CONTROL_RECEIVED_TOO_MUCH_DATA));

- EXPECT_FALSE(stream_->OnStreamFrame(frame));

+ stream_->OnStreamFrame(frame);

}

TEST_F(ReliableQuicStreamTest, FinalByteOffsetFromFin) {

« no previous file with comments | « net/quic/reliable_quic_stream.cc ('k') | net/tools/quic/quic_spdy_client_stream.h » ('j') | no next file with comments »