net/tools/quic/quic_spdy_client_stream.cc - Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/quic/quic_spdy_client_stream.cc

Issue 420393004: Change ReliableQuicStream::OnStreamFrame to return void since the method (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@visitor_for_tracegraf_71863508

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/tools/quic/quic_spdy_client_stream.cc

diff --git a/net/tools/quic/quic_spdy_client_stream.cc b/net/tools/quic/quic_spdy_client_stream.cc

index 8423295a1ac368c11690ba164b406bfbafb52bd1..394b52be0b68261d74fb484a0c8a6902c5a15440 100644

--- a/net/tools/quic/quic_spdy_client_stream.cc

+++ b/net/tools/quic/quic_spdy_client_stream.cc

@@ -28,13 +28,13 @@ QuicSpdyClientStream::QuicSpdyClientStream(QuicStreamId id,

QuicSpdyClientStream::~QuicSpdyClientStream() {

}

-bool QuicSpdyClientStream::OnStreamFrame(const QuicStreamFrame& frame) {

+void QuicSpdyClientStream::OnStreamFrame(const QuicStreamFrame& frame) {

if (!write_side_closed()) {

DVLOG(1) << "Got a response before the request was complete. "

<< "Aborting request.";

CloseWriteSide();

}

- return QuicDataStream::OnStreamFrame(frame);

+ QuicDataStream::OnStreamFrame(frame);

}

void QuicSpdyClientStream::OnStreamHeadersComplete(bool fin,

« no previous file with comments | « net/tools/quic/quic_spdy_client_stream.h ('k') | net/tools/quic/quic_spdy_client_stream_test.cc » ('j') | no next file with comments »