Issue 4174001: Port some GC fixes from the bleeding edge to the 2.4 branch. These are:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 4174001: Port some GC fixes from the bleeding edge to the 2.4 branch. These are:... (Closed)

Created:
10 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/2.4/

Visibility:
Public.

Port some GC fixes from the bleeding edge to the 2.4 branch. These are: 5627 and 5628: Fix creation of an exception to avoid a rare GC corner case. http://codereview.chromium.org/3782009 5640: Fix missing check for GC failure in number dictionary code. http://codereview.chromium.org/3781014 5674: Fix the --noinline-new flag on ARM so that it forces us into C++ code on every allocation. Fix three places where the generated code couldn't cope with an unlucky GC. http://codereview.chromium.org/3872003 5676: Fix GC error in ES5 read-only properties implementation. http://codereview.chromium.org/3920005 Committed: http://code.google.com/p/v8/source/detail?r=5702

Created: 10 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+185 lines, -35 lines)			Patch
M	src/arm/codegen-arm.cc	View	6 chunks	+30 lines, -25 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+22 lines, -0 lines	0 comments	Download
M	src/handles.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download
A	test/mjsunit/define-property-gc.js	View	1 chunk	+45 lines, -0 lines	0 comments	Download
M	test/mjsunit/math-min-max.js	View	1 chunk	+4 lines, -1 line	0 comments	Download
A	test/mjsunit/regress/regress-create-exception.js	View	1 chunk	+58 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Mads Ager (chromium)

10 years, 1 month ago (2010-10-26 09:16:44 UTC) #2

Please update version.cc.

Once that is done, LGTM.