src/arm/ic-arm.cc - Issue 4174001: Port some GC fixes from the bleeding edge to the 2.4 branch. These are:...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/ic-arm.cc

Issue 4174001: Port some GC fixes from the bleeding edge to the 2.4 branch. These are:... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.4/

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/ic-arm.cc

===================================================================

--- src/arm/ic-arm.cc (revision 5701)

+++ src/arm/ic-arm.cc (working copy)

@@ -1410,9 +1410,12 @@

__ bind(&box_int);

// Allocate a HeapNumber for the result and perform int-to-double

- // conversion. Use r0 for result as key is not needed any more.

+ // conversion. Don't touch r0 or r1 as they are needed if allocation

+ // fails.

__ LoadRoot(r6, Heap::kHeapNumberMapRootIndex);

- __ AllocateHeapNumber(r0, r3, r4, r6, &slow);

+ __ AllocateHeapNumber(r5, r3, r4, r6, &slow);

+ // Now we can use r0 for the result as key is not needed any more.

+ __ mov(r0, r5);

if (CpuFeatures::IsSupported(VFP3)) {

CpuFeatures::Scope scope(VFP3);

« no previous file with comments | « src/arm/codegen-arm.cc ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »