Issue 3872003: Fix the --noinline-new flag on ARM so that it forces us into C++ code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3872003: Fix the --noinline-new flag on ARM so that it forces us into C++ code... (Closed)

Created:
10 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix the --noinline-new flag on ARM so that it forces us into C++ code on every allocation. Fix three places where the generated code couldn't cope with an unlucky GC. Committed: http://code.google.com/p/v8/source/detail?r=5674

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 2 months ago

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -28 lines)
M	src/arm/codegen-arm.cc	View	6 chunks	+30 lines, -25 lines	1 comment
M	src/arm/ic-arm.cc	View	1 chunk	+4 lines, -2 lines	0 comments
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+22 lines, -0 lines	0 comments
M	test/mjsunit/math-min-max.js	View	1 chunk	+4 lines, -1 line	0 comments

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 2 months ago (2010-10-20 11:43:53 UTC) #2

LGTM!

http://codereview.chromium.org/3872003/diff/1/2
File src/arm/ic-arm.cc (right):

http://codereview.chromium.org/3872003/diff/1/2#newcode1413
src/arm/ic-arm.cc:1413: // conversion. Use r0 for result as key is not needed
any more if
Comment seems strange. Should be something like "don't touch r0 or r1 as they
are needed if allocation fails".

http://codereview.chromium.org/3872003/diff/5001/6001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/3872003/diff/5001/6001#newcode1481
src/arm/codegen-arm.cc:1481: Register scratch2 = VirtualFrame::scratch1();
scratch2 -> scratch?

Expand Messages | Collapse Messages