Issue 3781014: Fix missing check for GC failure in number dictionary code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3781014: Fix missing check for GC failure in number dictionary code. (Closed)

Created:
10 years, 2 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix missing check for GC failure in number dictionary code. Committed: http://code.google.com/p/v8/source/detail?r=5640

Patch Set 1 #

Total comments: 1

Created: 10 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/objects.cc	View		1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

10 years, 2 months ago (2010-10-18 10:04:16 UTC) #2

LGTM except for the name.

http://codereview.chromium.org/3781014/diff/1/2
File src/objects.cc (right):

http://codereview.chromium.org/3781014/diff/1/2#newcode8594
src/objects.cc:8594: Object* okey = NumberDictionaryShape::AsObject(key);
I don't like the name. key_object?

Expand Messages | Collapse Messages