Issue 415403005: [turbofan] Support for combining branches with <Operation>WithOverflow.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 415403005: [turbofan] Support for combining branches with <Operation>WithOverflow. (Closed)

Created:
6 years, 4 months ago by Benedikt Meurer

Modified:
6 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

[turbofan] Support for combining branches with <Operation>WithOverflow. Also unify the handling of binops in the InstructionSelector backends. TEST=cctest/test-run-machops,cctest/test-instruction-selector-arm R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22800

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+494 lines, -259 lines)			Patch
M	src/compiler/arm/instruction-selector-arm.cc	View	9 chunks	+39 lines, -67 lines	0 comments	Download
M	src/compiler/arm64/instruction-selector-arm64.cc	View	8 chunks	+42 lines, -38 lines	0 comments	Download
M	src/compiler/ia32/instruction-selector-ia32.cc	View	6 chunks	+32 lines, -41 lines	0 comments	Download
M	src/compiler/instruction-selector.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	src/compiler/instruction-selector.cc	View	9 chunks	+94 lines, -4 lines	0 comments	Download
M	src/compiler/instruction-selector-impl.h	View	6 chunks	+23 lines, -6 lines	0 comments	Download
M	src/compiler/machine-node-factory.h	View	1 chunk	+4 lines, -10 lines	0 comments	Download
M	src/compiler/node.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/compiler/node.cc	View	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/compiler/x64/instruction-selector-x64.cc	View	8 chunks	+40 lines, -53 lines	0 comments	Download
M	test/cctest/compiler/test-instruction-selector-arm.cc	View	15 chunks	+159 lines, -14 lines	0 comments	Download
M	test/cctest/compiler/test-run-machops.cc	View	10 chunks	+38 lines, -26 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Benedikt Meurer

6 years, 4 months ago (2014-08-04 08:18:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22800 (tree was closed).

Expand Messages | Collapse Messages