Always use the LoadStubCompiler for Load handlers, also for keyedload handlers.

Always use the LoadStubCompiler for Load handlers, also for keyedload handlers.

BUG=
R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=22551

[Toon Verwaest, 2014-07-22 15:40:09]

PTAL

[mvstanton, 2014-07-23 08:09:29]

Looks pretty good, just one question.

https://codereview.chromium.org/414443002/diff/40001/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/414443002/diff/40001/src/stub-cache.cc#newcod...
src/stub-cache.cc:1146: Code::Flags flags =
Code::ComputeFlags(Code::KEYED_LOAD_IC, MONOMORPHIC,
Why can't GetICCode() be used? Can it be moved in the class hierarchy and input
parameters changed so as to remain a viable library function for this kind of
thing?

[Toon Verwaest, 2014-07-23 10:28:42]

https://codereview.chromium.org/414443002/diff/40001/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/414443002/diff/40001/src/stub-cache.cc#newcod...
src/stub-cache.cc:1146: Code::Flags flags =
Code::ComputeFlags(Code::KEYED_LOAD_IC, MONOMORPHIC,
I'll move this stuff together in another CL in an ICCompiler.

On 2014/07/23 08:09:28, mvstanton wrote:
> Why can't GetICCode() be used? Can it be moved in the class hierarchy and
input
> parameters changed so as to remain a viable library function for this kind of
> thing?

[mvstanton, 2014-07-23 10:30:29]

lgtm

[Toon Verwaest, 2014-07-23 11:16:39]

Committed patchset #2 manually as r22551 (presubmit successful).