src/ia32/stub-cache-ia32.cc - Issue 414443002: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/stub-cache-ia32.cc

Issue 414443002: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Ensure that LoadIC can be used to compile keyed load ICs with shared load handlers Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/stub-cache-ia32.cc

diff --git a/src/ia32/stub-cache-ia32.cc b/src/ia32/stub-cache-ia32.cc

index 443ed4e7ee083195d10f715cd2cf502167207021..1a4e3f69da0281c0dd78352c04fdd45b24337250 100644

--- a/src/ia32/stub-cache-ia32.cc

+++ b/src/ia32/stub-cache-ia32.cc

@@ -968,13 +968,8 @@ void LoadStubCompiler::GenerateLoadField(Register reg,

FieldIndex field,

Representation representation) {

if (!reg.is(receiver())) __ mov(receiver(), reg);

- if (kind() == Code::LOAD_IC) {

- LoadFieldStub stub(isolate(), field);

- GenerateTailCall(masm(), stub.GetCode());

- } else {

- KeyedLoadFieldStub stub(isolate(), field);

- GenerateTailCall(masm(), stub.GetCode());

- }

+ LoadFieldStub stub(isolate(), field);

+ GenerateTailCall(masm(), stub.GetCode());

}

« no previous file with comments | « src/code-stubs.cc ('k') | src/ic.h » ('j') | src/stub-cache.cc » ('J')