Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: src/arm/stub-cache-arm.cc

Issue 414443002: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ensure that LoadIC can be used to compile keyed load ICs with shared load handlers Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | src/stub-cache.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_ARM 7 #if V8_TARGET_ARCH_ARM
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 986 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 HandlerFrontendFooter(name, &miss); 997 HandlerFrontendFooter(name, &miss);
998 return reg; 998 return reg;
999 } 999 }
1000 1000
1001 1001
1002 void LoadStubCompiler::GenerateLoadField(Register reg, 1002 void LoadStubCompiler::GenerateLoadField(Register reg,
1003 Handle<JSObject> holder, 1003 Handle<JSObject> holder,
1004 FieldIndex field, 1004 FieldIndex field,
1005 Representation representation) { 1005 Representation representation) {
1006 if (!reg.is(receiver())) __ mov(receiver(), reg); 1006 if (!reg.is(receiver())) __ mov(receiver(), reg);
1007 if (kind() == Code::LOAD_IC) { 1007 LoadFieldStub stub(isolate(), field);
1008 LoadFieldStub stub(isolate(), field); 1008 GenerateTailCall(masm(), stub.GetCode());
1009 GenerateTailCall(masm(), stub.GetCode());
1010 } else {
1011 KeyedLoadFieldStub stub(isolate(), field);
1012 GenerateTailCall(masm(), stub.GetCode());
1013 }
1014 } 1009 }
1015 1010
1016 1011
1017 void LoadStubCompiler::GenerateLoadConstant(Handle<Object> value) { 1012 void LoadStubCompiler::GenerateLoadConstant(Handle<Object> value) {
1018 // Return the constant value. 1013 // Return the constant value.
1019 __ Move(r0, value); 1014 __ Move(r0, value);
1020 __ Ret(); 1015 __ Ret();
1021 } 1016 }
1022 1017
1023 1018
(...skipping 485 matching lines...) Expand 10 before | Expand all | Expand 10 after
1509 1504
1510 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1505 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1511 } 1506 }
1512 1507
1513 1508
1514 #undef __ 1509 #undef __
1515 1510
1516 } } // namespace v8::internal 1511 } } // namespace v8::internal
1517 1512
1518 #endif // V8_TARGET_ARCH_ARM 1513 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/stub-cache-arm64.cc » ('j') | src/stub-cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698