Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: src/ia32/stub-cache-ia32.cc

Issue 414443002: Always use the LoadStubCompiler for Load handlers, also for keyedload handlers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Ensure that LoadIC can be used to compile keyed load ICs with shared load handlers Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic.h » ('j') | src/stub-cache.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_IA32 7 #if V8_TARGET_ARCH_IA32
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/ic-inl.h" 10 #include "src/ic-inl.h"
(...skipping 950 matching lines...) Expand 10 before | Expand all | Expand 10 after
961 HandlerFrontendFooter(name, &miss); 961 HandlerFrontendFooter(name, &miss);
962 return reg; 962 return reg;
963 } 963 }
964 964
965 965
966 void LoadStubCompiler::GenerateLoadField(Register reg, 966 void LoadStubCompiler::GenerateLoadField(Register reg,
967 Handle<JSObject> holder, 967 Handle<JSObject> holder,
968 FieldIndex field, 968 FieldIndex field,
969 Representation representation) { 969 Representation representation) {
970 if (!reg.is(receiver())) __ mov(receiver(), reg); 970 if (!reg.is(receiver())) __ mov(receiver(), reg);
971 if (kind() == Code::LOAD_IC) { 971 LoadFieldStub stub(isolate(), field);
972 LoadFieldStub stub(isolate(), field); 972 GenerateTailCall(masm(), stub.GetCode());
973 GenerateTailCall(masm(), stub.GetCode());
974 } else {
975 KeyedLoadFieldStub stub(isolate(), field);
976 GenerateTailCall(masm(), stub.GetCode());
977 }
978 } 973 }
979 974
980 975
981 void LoadStubCompiler::GenerateLoadCallback( 976 void LoadStubCompiler::GenerateLoadCallback(
982 Register reg, 977 Register reg,
983 Handle<ExecutableAccessorInfo> callback) { 978 Handle<ExecutableAccessorInfo> callback) {
984 // Insert additional parameters into the stack frame above return address. 979 // Insert additional parameters into the stack frame above return address.
985 ASSERT(!scratch3().is(reg)); 980 ASSERT(!scratch3().is(reg));
986 __ pop(scratch3()); // Get return address to place it below. 981 __ pop(scratch3()); // Get return address to place it below.
987 982
(...skipping 513 matching lines...) Expand 10 before | Expand all | Expand 10 after
1501 // ----------------------------------- 1496 // -----------------------------------
1502 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss); 1497 TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
1503 } 1498 }
1504 1499
1505 1500
1506 #undef __ 1501 #undef __
1507 1502
1508 } } // namespace v8::internal 1503 } } // namespace v8::internal
1509 1504
1510 #endif // V8_TARGET_ARCH_IA32 1505 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/code-stubs.cc ('k') | src/ic.h » ('j') | src/stub-cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698