Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 414013005: Merge GrGpuObject and GrCacheable. (Closed)

Created:
6 years, 5 months ago by bsalomon
Modified:
6 years, 5 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@uniqueid
Visibility:
Public.

Description

Merge GrGpuObject and GrCacheable. We want to create a new base class for "meta" gr resources as part of the GrResourceCache rewrite and this is an iterim step towards that goal.s Committed: https://skia.googlesource.com/skia/+/c44be0e9e4cee5402909c06370a630eee188a8f3

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -202 lines) Patch
M bench/GrResourceCacheBench.cpp View 10 chunks +21 lines, -23 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +0 lines, -2 lines 0 comments Download
D include/gpu/GrCacheable.h View 1 chunk +0 lines, -93 lines 0 comments Download
M include/gpu/GrContext.h View 2 chunks +2 lines, -3 lines 0 comments Download
M include/gpu/GrGpuObject.h View 1 5 chunks +57 lines, -13 lines 0 comments Download
M include/gpu/GrTexture.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/gpu/GrAtlas.h View 1 chunk +2 lines, -1 line 0 comments Download
D src/gpu/GrCacheable.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M src/gpu/GrContext.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrGpu.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrGpuObject.cpp View 3 chunks +14 lines, -1 line 0 comments Download
M src/gpu/GrResourceCache.h View 8 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/GrResourceCache.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M src/gpu/GrStencilAndCoverTextContext.cpp View 1 3 chunks +18 lines, -5 lines 0 comments Download
M tests/ResourceCacheTest.cpp View 11 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bsalomon
6 years, 5 months ago (2014-07-24 20:54:21 UTC) #1
robertphillips
lgtm + nits https://codereview.chromium.org/414013005/diff/1/include/gpu/GrGpuObject.h File include/gpu/GrGpuObject.h (right): https://codereview.chromium.org/414013005/diff/1/include/gpu/GrGpuObject.h#newcode7 include/gpu/GrGpuObject.h:7: Shouldn't we keep this matching the ...
6 years, 5 months ago (2014-07-25 12:53:06 UTC) #2
bsalomon
https://codereview.chromium.org/414013005/diff/1/include/gpu/GrGpuObject.h File include/gpu/GrGpuObject.h (right): https://codereview.chromium.org/414013005/diff/1/include/gpu/GrGpuObject.h#newcode7 include/gpu/GrGpuObject.h:7: On 2014/07/25 12:53:06, robertphillips wrote: > Shouldn't we keep ...
6 years, 5 months ago (2014-07-25 14:20:53 UTC) #3
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 5 months ago (2014-07-25 14:20:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/414013005/20001
6 years, 5 months ago (2014-07-25 14:21:27 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 14:32:38 UTC) #6
Message was sent while issue was closed. 
Change committed as c44be0e9e4cee5402909c06370a630eee188a8f3

Powered by Google App Engine
This is Rietveld 408576698