posix: upgrade libevent from 1.4.7 to 1.4.13

posix: upgrade libevent from 1.4.7 to 1.4.13

I took this opportunity to rejigger how we hacked around using an uninstalled
libevent, to remove a TODO that mentioned danger in the README.

Files to review: README.chromium and chromium.patch.
The rest are probably rubber-stampable.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32656

[Evan Martin, 2009-11-20 07:08:33]

agl should still be the reviewer, but adding a couple people who might like to
be aware of this change when it lands

[dank, 2009-11-20 08:52:32]

LGTM

[Mark Mentovai, 2009-11-20 16:31:33]

LGTM

http://codereview.chromium.org/412006/diff/2001/3001
File third_party/libevent/ChangeLog (right):

http://codereview.chromium.org/412006/diff/2001/3001#newcode17
Line 17: o Fix another pair of fencepost bugs in epoll.c.  [Patch from Adam
Langley.]
nice

http://codereview.chromium.org/412006/diff/2001/3001#newcode20
Line 20: o Disable strict aliasing with GCC: our code is not compliant with it.
Does this need any attention on our side?

http://codereview.chromium.org/412006/diff/2001/3001#newcode40
Line 40: o event_add would not return error for some backends; from Dean McNamee
nice

http://codereview.chromium.org/412006/diff/2001/3004
File third_party/libevent/README.chromium (right):

http://codereview.chromium.org/412006/diff/2001/3004#newcode1
Line 1: This is a copy of libevent-1.4.13-stable for use on Linux and Mac.
I personally don't care, but these files are supposed to contain "License" and
"License File".

Also, I like to put a URL to the upstream project's home, and a URL to the
specific source that's checked in.

See third_party/ocmock/README.chromium - that's the "standard form" we're
supposed to use, although I don't care if these files aren't in that form as
long as the relevant information is at the top.

http://codereview.chromium.org/412006/diff/2001/3004#newcode4
Line 4: static library using gyp.
GYP in capitals, it's an acronym.

http://codereview.chromium.org/412006/diff/2001/3004#newcode11
Line 11: being installed.
and to let us use the checked-in event-config.h files.

http://codereview.chromium.org/412006/diff/2001/3004#newcode14
Line 14: SConscript does not include a few files that don't build on Linux:
What's SConscript?

http://codereview.chromium.org/412006/diff/2001/3007
File third_party/libevent/chromium.patch (right):

http://codereview.chromium.org/412006/diff/2001/3007#newcode19
Line 19: +#error FIXME
Could be a tiny bit more descriptive.  Same in the source,
third_party/libevent/event-config.h.

[agl, 2009-11-20 20:06:05]

LGTM. Mark hits every point that I might have made.