Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: third_party/libevent/README.chromium

Issue 412006: posix: upgrade libevent from 1.4.7 to 1.4.13 (Closed)
Patch Set: better readme Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/libevent/README.chromium
diff --git a/third_party/libevent/README.chromium b/third_party/libevent/README.chromium
index 1cbdd80041d399b2819dca7d71204ab3c02cc643..9c6df86d53a30193ea8ddc683fc5bce53b3bc62e 100644
--- a/third_party/libevent/README.chromium
+++ b/third_party/libevent/README.chromium
@@ -1,21 +1,15 @@
-This contains a copy of libevent-1.4.7-stable for use on Linux and Mac
+This is a copy of libevent-1.4.13-stable for use on Linux and Mac.
Mark Mentovai 2009/11/20 16:31:33 I personally don't care, but these files are suppo
-Rather than use libevent's own build system, we just build a Chrome
-static library using SConscript
+Rather than use libevent's own build system, we just build a Chrome
+static library using gyp.
Mark Mentovai 2009/11/20 16:31:33 GYP in capitals, it's an acronym.
Changes from upstream:
-1) add linux/config.h from a run of configure on a Linux development box.
-2) add SConscript and libevent.gyp
-3) quotes.patch is applied to allow libevent to be used without
-being installed (alternative is adding crazy -I arguments to the commandline)
-4) The directories WIN32-Code and WIN32-Prj are not included
-5) add mac/config.h from a run of configure on a Mac.
-6) sys-queue-macros.patch is applied to build on systems which are missing a
-complete sys/queue.h
+1) Run configure and "make event-config.h" on a Linux and Mac box and
+ copy config.h and event-config.h to linux/ and mac/ respectively.
+2) Add libevent.gyp.
+3) chromium.patch is applied to allow libevent to be used without
+ being installed.
Mark Mentovai 2009/11/20 16:31:33 and to let us use the checked-in event-config.h fi
+4) The directories WIN32-Code and WIN32-Prj are not included.
SConscript does not include a few files that don't build on Linux:
Mark Mentovai 2009/11/20 16:31:33 What's SConscript?
devpoll.c, evport.c, kqueue.c
-
-TODO: currently we -I the source directory, which exposes event-config.h, which
-is dangerous as this file was generated for Linux and is not entirely correct on
-other platforms.

Powered by Google App Engine
This is Rietveld 408576698