Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(744)

Side by Side Diff: third_party/libevent/README.chromium

Issue 412006: posix: upgrade libevent from 1.4.7 to 1.4.13 (Closed)
Patch Set: better readme Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 This contains a copy of libevent-1.4.7-stable for use on Linux and Mac 1 This is a copy of libevent-1.4.13-stable for use on Linux and Mac.
Mark Mentovai 2009/11/20 16:31:33 I personally don't care, but these files are suppo
2 2
3 Rather than use libevent's own build system, we just build a Chrome 3 Rather than use libevent's own build system, we just build a Chrome
4 static library using SConscript 4 static library using gyp.
Mark Mentovai 2009/11/20 16:31:33 GYP in capitals, it's an acronym.
5 5
6 Changes from upstream: 6 Changes from upstream:
7 1) add linux/config.h from a run of configure on a Linux development box. 7 1) Run configure and "make event-config.h" on a Linux and Mac box and
8 2) add SConscript and libevent.gyp 8 copy config.h and event-config.h to linux/ and mac/ respectively.
9 3) quotes.patch is applied to allow libevent to be used without 9 2) Add libevent.gyp.
10 being installed (alternative is adding crazy -I arguments to the commandline) 10 3) chromium.patch is applied to allow libevent to be used without
11 4) The directories WIN32-Code and WIN32-Prj are not included 11 being installed.
Mark Mentovai 2009/11/20 16:31:33 and to let us use the checked-in event-config.h fi
12 5) add mac/config.h from a run of configure on a Mac. 12 4) The directories WIN32-Code and WIN32-Prj are not included.
13 6) sys-queue-macros.patch is applied to build on systems which are missing a
14 complete sys/queue.h
15 13
16 SConscript does not include a few files that don't build on Linux: 14 SConscript does not include a few files that don't build on Linux:
Mark Mentovai 2009/11/20 16:31:33 What's SConscript?
17 devpoll.c, evport.c, kqueue.c 15 devpoll.c, evport.c, kqueue.c
18
19 TODO: currently we -I the source directory, which exposes event-config.h, which
20 is dangerous as this file was generated for Linux and is not entirely correct on
21 other platforms.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698