Simplify failing builder lists.

Simplify failing builder lists.

-Get rid of the "BUILDING" category. In order to make this work,
we'll need to plumb through a list of builders for each testtype/waterfall
combination. While we have that information for the flakiness dashboard,
it just doesn't seem worth it for this feature.
-Stop trying to do complicated things with the builder name
and just show the raw builder name. It takes up more space,
but it scales better to the full list of chromium builders and
is less complexity for sheriffs to understand.
-Once we've done the above, stop plumbing builderLatestRevisions
everywhere. Technically it's dead code now, but Levi's patch
in progress is using it, so I don't feel compelled to delete it.
-Finally, we can now remove config.js entirely.

NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178625

[abarth-chromium, 2014-07-22 05:56:57]

lgtm

[commit-bot: I haz the power, 2014-07-22 05:57:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ojan@chromium.org/409063002/20001

[commit-bot: I haz the power, 2014-07-22 05:57:44]

Change committed as 178625

[michaelpg, 2014-07-22 05:58:23]

Sorry I made you have to undo all this stuff. Glad it's being simplified though,
if we don't want this feature.

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-commit-log.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-commit-log.html:33: var commit = new
CTCommit(author, message, 'http://src.chromium.org/viewvc/blink');
why is it better for this to be hard-coded? what will change when we want to
show chromium commits?

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-builder-grid.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-builder-grid.html:101:
this._resultTypes[result][builder] = 1;
So can we just make this an array, then, instead of using _keys()?

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-builder.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-builder.html:50: // FIXME: Pass in the waterfall URL
instead so this can work with different waterfalls.
why not just do this now?

[ojan, 2014-07-22 06:08:50]

On 2014/07/22 at 05:58:23, michaelpg wrote:
> Sorry I made you have to undo all this stuff.

Not at all. It wasn't clear to me that we should simplify it until I went to try
to make it work more generally for the non-webkit bots. One could just as easily
argue that we should keep this functionality and make it work more generally.
Laziness and a sense of urgency for a minimal viable product made me lean toward
deleting the functionality for now. We can always add it back in later if we
think it's needed.

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/mo...
File Tools/GardeningServer/model/ct-commit-log.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/mo...
Tools/GardeningServer/model/ct-commit-log.html:33: var commit = new
CTCommit(author, message, 'http://src.chromium.org/viewvc/blink');
We'll need to pass this information through in the constructor. So, hard-coding
it here for now made sense to me.

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-builder-grid.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-builder-grid.html:101:
this._resultTypes[result][builder] = 1;
We need to dedupe the builders, so we'd need to do something like the current
code and then convert it to an array at the end. That didn't seem clearly better
to me and since this structure is private to this component, I didn't think too
hard about it.

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
File Tools/GardeningServer/ui/ct-builder.html (right):

https://codereview.chromium.org/409063002/diff/20001/Tools/GardeningServer/ui...
Tools/GardeningServer/ui/ct-builder.html:50: // FIXME: Pass in the waterfall URL
instead so this can work with different waterfalls.
We need to plumb the waterfall url all the way from ct-failure-analyzer to here.
Just wanted to keep this patch small.