Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Tools/GardeningServer/model/ct-commit-log.html

Issue 409063002: Simplify failing builder lists. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make resultTypes private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!-- 1 <!--
2 Copyright 2014 The Chromium Authors. All rights reserved. 2 Copyright 2014 The Chromium Authors. All rights reserved.
3 Use of this source code is governed by a BSD-style license that can be 3 Use of this source code is governed by a BSD-style license that can be
4 found in the LICENSE file. 4 found in the LICENSE file.
5 --> 5 -->
6 6
7 <link rel='import' href='ct-commit.html'> 7 <link rel='import' href='ct-commit.html'>
8 8
9 <script> 9 <script>
10 function CTCommitLog() { 10 function CTCommitLog() {
(...skipping 12 matching lines...) Expand all
23 CTCommitLog.prototype.update = function() { 23 CTCommitLog.prototype.update = function() {
24 // FIXME: Turn net.js into net.html and import it at the top of this file. 24 // FIXME: Turn net.js into net.html and import it at the top of this file.
25 return net.xml('http://blink.lc/blink/atom').then(this._processXml.bind(this)) ; 25 return net.xml('http://blink.lc/blink/atom').then(this._processXml.bind(this)) ;
26 } 26 }
27 27
28 CTCommitLog.prototype._processXml = function(xml) { 28 CTCommitLog.prototype._processXml = function(xml) {
29 Array.prototype.forEach.call(xml.getElementsByTagName('entry'), function(logen try) { 29 Array.prototype.forEach.call(xml.getElementsByTagName('entry'), function(logen try) {
30 var author = logentry.getElementsByTagName('author')[0].textContent.trim(); 30 var author = logentry.getElementsByTagName('author')[0].textContent.trim();
31 var message = logentry.getElementsByTagName('content')[0].textContent.trim() ; 31 var message = logentry.getElementsByTagName('content')[0].textContent.trim() ;
32 // FIXME: Handle base urls for different repos. 32 // FIXME: Handle base urls for different repos.
33 // FIXME: This class should import config.js if it keeps using config.*. 33 var commit = new CTCommit(author, message, 'http://src.chromium.org/viewvc/b link');
michaelpg 2014/07/22 05:58:23 why is it better for this to be hard-coded? what w
ojan 2014/07/22 06:08:50 We'll need to pass this information through in the
34 var commit = new CTCommit(author, message, config.kBlinkRevisionURL);
35 this.commits[commit.revision] = commit; 34 this.commits[commit.revision] = commit;
36 }.bind(this)); 35 }.bind(this));
37 } 36 }
38 </script> 37 </script>
OLDNEW
« no previous file with comments | « no previous file | Tools/GardeningServer/model/ct-commit-mock.html » ('j') | Tools/GardeningServer/ui/ct-builder.html » ('J')

Powered by Google App Engine
This is Rietveld 408576698