Simplify failing builder lists.

Tools/GardeningServer/ui/ct-builder-grid.html

 <!--
 Copyright 2014 The Chromium Authors. All rights reserved.
 Use of this source code is governed by a BSD-style license that can be
 found in the LICENSE file.
 -->
 
 <link rel="import" href="ct-builder.html">
 
 <!-- Table of failure types, listing the failing builders for each type. -->
-<polymer-element name="ct-builder-grid" attributes="failures builderLatestRevisions">
+<polymer-element name="ct-builder-grid" attributes="failures">
   <template>
     <style>
       table {
         border-collapse: collapse;
         font-size: 11px;
         table-layout: fixed;
         width: 350px;
       }
 
       tbody td:first-child {
@@ skipping 36 matching lines @@
 
       .MISSING span {
         padding-left: 0px;
       }
 
       .BUILDING, .BUILDING ~ td {
         opacity: 0.5;
       }
     </style>
     <table>
-      <thead>
-        <tr>
-          <td>type</td>
-          <td>release</td>
-          <td>debug</td>
-        </tr>
-      </thead>
       <tbody>
-        <template repeat="{{ type in resultTypes|resultTypeKeys }}">
+        <template repeat="{{ type in _resultTypes | _keys }}">
           <tr>
             <td class="{{ type }}">
               <span>{{ type }}</span>
             </td>
             <td>
-              <template repeat="{{ builder in resultTypes[type]|keys }}">
-                <template if="{{ !resultTypes[type][builder].debug }}">
-                  <ct-builder builderName="{{ builder }}"></ct-builder>
-                </template>
-              </template>
-            </td>
-            <td>
-              <template repeat="{{ builder in resultTypes[type]|keys }}">
-                <template if="{{ resultTypes[type][builder].debug }}">
-                  <ct-builder builderName="{{ builder }}"></ct-builder>
-                </template>
+              <template repeat="{{ builder in _resultTypes[type] | _keys }}">
+                <ct-builder builder="{{ builder }}"></ct-builder>
               </template>
             </td>
           </tr>
         </template>
       </tbody>
     </table>
   </template>
   <script>
     Polymer({
       failures: [],
-      builderLatestRevisions: {},
-      resultTypes: {},
+      _resultTypes: {},
 
-      keys: function(obj) {
+      _keys: function(obj) {
         return Object.keys(obj).sort();
       },
 
-      resultTypeKeys: function(obj) {
-        // Get the keys, but the BUILDING type should be last.
-        var keys = this.keys(obj);
-        var index = keys.indexOf('BUILDING');
-        if (index != -1) {
-          var buildingResult = keys.splice(index, 1);
-          keys.push(buildingResult[0]);
-        }
-        return keys;
-      },
-
       failuresChanged: function() {
         // Create a set of builders for each result type (e.g., text, crash).
-        this.resultTypes = {};
-        var passingRevisions = [];
+        this._resultTypes = {};
         this.failures.forEach(function(failure) {
-          passingRevisions.push(failure.newestPassingRevision);
           var results = failure.resultNodesByBuilder;
           Object.keys(results, (function(builder) {
             var result = results[builder].actual;
-            if (!Object.has(this.resultTypes, result))
-              this.resultTypes[result] = {};
-            this.resultTypes[result][builder] =
-                config.builders[builder];
+            if (!this._resultTypes[result])
+              this._resultTypes[result] = {};
+            this._resultTypes[result][builder] = 1;

[michaelpg, 2014/07/22 05:58:23]

So can we just make this an array, then, instead of using _keys()?

[ojan, 2014/07/22 06:08:50]

We need to dedupe the builders, so we'd need to do something like the current
code and then convert it to an array at the end. That didn't seem clearly better
to me and since this structure is private to this component, I didn't think too
hard about it.

           }).bind(this));
         }, this);
-
-        var buildingType = this._getBuilding(passingRevisions);
-        if (!Object.isEmpty(buildingType))
-            this.resultTypes['BUILDING'] = buildingType;
-      },
-
-      _buildersInFlightForRevision: function(revision) {
-        return Object.keys(this.builderLatestRevisions).filter(function(builder) {
-          // FIXME: This should look at all chromium/v8/etc revisions as well.
-          // Is this concept of "building" builders even useful as is?
-          return parseInt(this.builderLatestRevisions[builder].blink, 10) < revision;
-        }.bind(this));
-      },
-
-      _getBuilding: function(revisions) {
-        var building = {};
-        var builders = [];
-        revisions.unique().forEach(function(revision) {
-          builders.push.apply(builders, this._buildersInFlightForRevision(revision + 1));
-        }.bind(this));
-
-        builders.unique().forEach(function(builder) {
-          if (!config.builders[builder])
-            return;
-          building[builder] = {'debug': config.builders[builder].debug};
-        });
-
-        return building;
       },
     });
   </script>
 </polymer-element>