Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1578)

Unified Diff: Tools/GardeningServer/ui/ct-builder.html

Issue 409063002: Simplify failing builder lists. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: make resultTypes private Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/GardeningServer/ui/ct-builder.html
diff --git a/Tools/GardeningServer/ui/ct-builder.html b/Tools/GardeningServer/ui/ct-builder.html
index cd8c6fc3698d7de65b0b50119643f2633da508bb..d2406a4578ab323e4bbe429a3c4a70c6d9cb228a 100644
--- a/Tools/GardeningServer/ui/ct-builder.html
+++ b/Tools/GardeningServer/ui/ct-builder.html
@@ -9,52 +9,30 @@ Styled link to a builder composed of the version and architecture, or the
builder name if the builder is unknown. If an array is passed to |steps|, the
link will show the builder name and architecture followed by the steps instead.
-->
-<polymer-element name="ct-builder" attributes="builderName steps">
+<polymer-element name="ct-builder" attributes="builder steps">
<template>
<style>
a {
border: 1px solid gray;
color: black;
display: inline-block;
- font-size: 0px;
+ font-size: 11px;
margin-bottom: 2px;
padding: 1px;
text-decoration: none;
}
span {
- font-size: 11px;
padding: 0 2px;
}
- .version {
+ .builder {
background-color: #555;
color: white;
}
-
- .version:not(.architecture) {
- text-transform: uppercase;
- }
-
- .details {
- padding-left: 3px;
- }
</style>
- <a href="{{ builderName|builderURL }}">
- <template if="{{ configuration }}">
- <span class="version">{{ configuration.version }}</span>
- <template if="{{ configuration.is64bit }}">
- <template if="{{ stepList }}">
- <span class="version architecture">64-bit</span>
- </template>
- <template if="{{ !stepList }}">
- <span>64-bit</span>
- </template>
- </template>
- </template>
- <template if="{{ !configuration }}">
- <span class="version">{{ builderName }}</span>
- </template>
+ <a href="{{ builder|builderURL }}">
+ <span class="builder">{{ builder }}</span>
<template if="{{ stepList }}">
<span class="details">{{ stepList }}</span>
</template>
@@ -64,17 +42,16 @@ link will show the builder name and architecture followed by the steps instead.
Polymer({
steps: [],
- ready: function() {
- this.configuration = config.builders[this.builderName];
- },
-
stepsChanged: function() {
this.stepList = this.steps.join(', ');
},
builderURL: function() {
- return config.waterfallURL + '?builder=' +
- encodeURIComponent(this.builderName);
+ // FIXME: Pass in the waterfall URL instead so this can work with different waterfalls.
michaelpg 2014/07/22 05:58:23 why not just do this now?
ojan 2014/07/22 06:08:50 We need to plumb the waterfall url all the way fro
+ var waterfall = 'http://build.chromium.org/p/chromium.webkit';
+ return waterfall + '/waterfall?' + Object.toQueryString({
+ builder: this.builder,
+ });
},
});
</script>

Powered by Google App Engine
This is Rietveld 408576698