Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 408813007: Remove non-standard API entry points in CanvasRenderingContext2D (Closed)

Created:
6 years, 5 months ago by Justin Novosad
Modified:
6 years, 1 month ago
Reviewers:
haraken, Stephen White
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, Inactive, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove non-standard API entry points in CanvasRenderingContext2D Rmoving the API entry points for the following 2d canvas methods: setAlpha setCompositingOperation setLineWidth setLineCap setLineJoin setMiterLimit clearShadow setStrokeColor setFillColor drawImageFromRect setShadow According to usage statistics, these entry points are not used anywhere on the web. They are undocumented and redundant with existing standard APIs. BUG=363198, 363165, 363166, 363180, 363181, 363184, 363185, 363186, 363188, 363189, 363191 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185835

Patch Set 1 #

Patch Set 2 : Adjust layout tests #

Patch Set 3 : fixing more tests #

Patch Set 4 : adding missing test result #

Patch Set 5 : update #

Total comments: 2

Patch Set 6 : remove some unnecessary mac/virtual/gpu baselines #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1127 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
D LayoutTests/canvas/stroke-with-system-color-and-alpha-crash.html View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/canvas/stroke-with-system-color-and-alpha-crash-expected.txt View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/canvas-color-serialization-expected.txt View 1 2 chunks +0 lines, -101 lines 0 comments Download
M LayoutTests/fast/canvas/canvas-currentColor-expected.txt View 1 3 2 chunks +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-drawImageFromRect-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setFillColor.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setFillColor-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setShadow.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setShadow-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setStrokeColor.html View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/canvas/canvas-overloads-setStrokeColor-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource.html View 1 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/canvas/drawImageFromRect_withToDataURLAsSource-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/image-object-in-canvas.html View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/canvas/resources/shadow-offset.js View 1 1 chunk +4 lines, -1 line 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-color-serialization.js View 1 3 chunks +0 lines, -191 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/canvas-currentColor.js View 1 2 chunks +0 lines, -24 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-overloads-drawImageFromRect.js View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-overloads-setFillColor.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-overloads-setShadow.js View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/canvas/script-tests/canvas-overloads-setStrokeColor.js View 1 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/canvas/script-tests/set-colors.js View 1 4 chunks +0 lines, -49 lines 0 comments Download
M LayoutTests/fast/canvas/set-colors-expected.txt View 1 2 chunks +0 lines, -30 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-2.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-2-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-3.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-3-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-4.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-4-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-5.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-5-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-6.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-6-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-7.html View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/fast/canvas/shadow-offset-7-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-2-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-3-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-4-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-5-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-6-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/fast/canvas/shadow-offset-7-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-2-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-3-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-4-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-5-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-6-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/linux/virtual/gpu/fast/canvas/shadow-offset-7-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-2-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-3-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-4-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-5-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-6-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/canvas/shadow-offset-7-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-currentColor-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -57 lines 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/set-colors-expected.txt View 1 2 3 4 5 1 chunk +0 lines, -71 lines 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-2-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-3-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-4-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-5-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-6-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/mac/virtual/gpu/fast/canvas/shadow-offset-7-expected.png View 1 2 3 4 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-2-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-3-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-4-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-5-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-6-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/fast/canvas/shadow-offset-7-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-2-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-3-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-4-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-5-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-6-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win-xp/virtual/gpu/fast/canvas/shadow-offset-7-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-2-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-3-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-4-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-5-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-6-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/fast/canvas/shadow-offset-7-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-2-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-3-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-4-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-5-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-6-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/win/virtual/gpu/fast/canvas/shadow-offset-7-expected.png View 1 Binary file 0 comments Download
M Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.h View 1 2 3 4 2 chunks +0 lines, -31 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 1 2 3 4 3 chunks +0 lines, -167 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.idl View 1 2 3 4 1 chunk +0 lines, -24 lines 0 comments Download

Messages

Total messages: 18 (4 generated)
Justin Novosad
PTAL
6 years, 5 months ago (2014-07-21 20:39:49 UTC) #1
Stephen White
This looks ok (once the test failures are fixed), but I'd like Eric to take ...
6 years, 5 months ago (2014-07-22 18:00:31 UTC) #2
Justin Novosad
On 2014/07/22 18:00:31, Stephen White wrote: > This looks ok (once the test failures are ...
6 years, 5 months ago (2014-07-22 18:11:12 UTC) #3
Justin Novosad
This got all the requires LGTMs on blink-dev. Several months of usage metrics show no ...
6 years, 1 month ago (2014-11-21 18:45:22 UTC) #4
Stephen White
https://codereview.chromium.org/408813007/diff/80001/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/408813007/diff/80001/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode81 Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp:81: impl->setStrokeStyle(CanvasStyle::createFromString(colorString)); Intentional change?
6 years, 1 month ago (2014-11-21 20:02:32 UTC) #5
Justin Novosad
https://codereview.chromium.org/408813007/diff/80001/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp File Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp (right): https://codereview.chromium.org/408813007/diff/80001/Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp#newcode81 Source/bindings/core/v8/custom/V8CanvasRenderingContext2DCustom.cpp:81: impl->setStrokeStyle(CanvasStyle::createFromString(colorString)); On 2014/11/21 20:02:32, Stephen White wrote: > Intentional ...
6 years, 1 month ago (2014-11-21 20:17:02 UTC) #6
Justin Novosad
New patch. Fixed failure on mac caused by unnecessary platform-specific baseline overloads.
6 years, 1 month ago (2014-11-21 21:06:31 UTC) #7
Stephen White
LGTM
6 years, 1 month ago (2014-11-21 21:21:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/408813007/100001
6 years, 1 month ago (2014-11-21 22:31:44 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20464)
6 years, 1 month ago (2014-11-21 22:38:13 UTC) #12
Justin Novosad
Looks like I was missing a Source/bindings OWNER +haraken
6 years, 1 month ago (2014-11-21 23:55:15 UTC) #14
haraken
bindings LGTM
6 years, 1 month ago (2014-11-22 00:57:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/408813007/100001
6 years, 1 month ago (2014-11-22 02:53:07 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-11-22 02:56:15 UTC) #18
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185835

Powered by Google App Engine
This is Rietveld 408576698