Make RenderPass::Id an isolated class

Make RenderPass::Id an isolated class

Move RenderPass::Id out of RenderPass and make it an isolated class
called RenderPassId, so RenderPassDrawQuad and AppendQuadsData will not
need to depend on entire RenderPass class.

This is a clean up CL for CL 448303002 to avoid circular dependency
issue for RenderPass and RenderPassDrawQuad class. 

BUG=344962
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291403

[weiliangc, 2014-08-20 23:30:04]

danakj: cc
jamesr: mojo
kenrb: cc_messages*
kbr: content/browser/renderer_host

[jamesr, 2014-08-20 23:32:15]

lgtm

https://codereview.chromium.org/404563005/diff/80001/cc/cc.gyp
File cc/cc.gyp (right):

https://codereview.chromium.org/404563005/diff/80001/cc/cc.gyp#newcode327
cc/cc.gyp:327: 'quads/render_pass_id.cc',
please update cc/BUILD.gn as well

[Ken Russell (switch to Gerrit), 2014-08-20 23:50:44]

content/browser/renderer_host lgtm

[danakj, 2014-08-20 23:54:08]

LGTM

https://codereview.chromium.org/404563005/diff/80001/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/layers/layer_impl.h#n...
cc/layers/layer_impl.h:27: #include "cc/quads/render_pass.h"
can be forward declared now instead?

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h
File cc/output/renderer.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h#new...
cc/output/renderer.h:10: #include "cc/quads/render_pass.h"
can forward declare RenderPass{ID,List} now?

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
File cc/surfaces/surface_aggregator_test_helpers.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
cc/surfaces/surface_aggregator_test_helpers.h:9: #include
"cc/quads/render_pass.h"
can forward declare RenderPass{List,} and RenderPassId?

[weiliangc, 2014-08-21 15:37:23]

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h
File cc/output/renderer.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h#new...
cc/output/renderer.h:10: #include "cc/quads/render_pass.h"
On 2014/08/20 23:54:08, danakj wrote:
> can forward declare RenderPass{ID,List} now?

Same as below.

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
File cc/surfaces/surface_aggregator_test_helpers.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
cc/surfaces/surface_aggregator_test_helpers.h:9: #include
"cc/quads/render_pass.h"
On 2014/08/20 23:54:08, danakj wrote:
> can forward declare RenderPass{List,} and RenderPassId?

RenderPassList is a typedef, not possible to forward declare to my
understanding.

[weiliangc, 2014-08-21 17:17:54]

https://codereview.chromium.org/404563005/diff/80001/cc/cc.gyp
File cc/cc.gyp (right):

https://codereview.chromium.org/404563005/diff/80001/cc/cc.gyp#newcode327
cc/cc.gyp:327: 'quads/render_pass_id.cc',
On 2014/08/20 23:32:15, jamesr wrote:
> please update cc/BUILD.gn as well

Done.

https://codereview.chromium.org/404563005/diff/80001/cc/layers/layer_impl.h
File cc/layers/layer_impl.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/layers/layer_impl.h#n...
cc/layers/layer_impl.h:27: #include "cc/quads/render_pass.h"
On 2014/08/20 23:54:08, danakj wrote:
> can be forward declared now instead?

Done.

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h
File cc/output/renderer.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/output/renderer.h#new...
cc/output/renderer.h:10: #include "cc/quads/render_pass.h"
On 2014/08/20 23:54:08, danakj wrote:
> can forward declare RenderPass{ID,List} now?

Done.

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
File cc/surfaces/surface_aggregator_test_helpers.h (right):

https://codereview.chromium.org/404563005/diff/80001/cc/surfaces/surface_aggr...
cc/surfaces/surface_aggregator_test_helpers.h:9: #include
"cc/quads/render_pass.h"
On 2014/08/20 23:54:08, danakj wrote:
> can forward declare RenderPass{List,} and RenderPassId?

Done.

[kenrb, 2014-08-21 19:12:13]

ipc lgtm

[weiliangc, 2014-08-21 19:14:34]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-08-21 19:20:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/404563005/100001

[commit-bot: I haz the power, 2014-08-21 20:20:40]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44847)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/50029)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[weiliangc, 2014-08-21 20:22:05]

The CQ bit was unchecked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-08-21 20:27:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 20:27:59]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/44864)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[weiliangc, 2014-08-21 20:32:00]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-08-21 20:37:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/404563005/120001

[commit-bot: I haz the power, 2014-08-21 21:54:00]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-21 22:07:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-21 22:07:54]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[weiliangc, 2014-08-21 23:45:01]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-08-21 23:49:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/404563005/140001

[commit-bot: I haz the power, 2014-08-22 01:11:07]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[commit-bot: I haz the power, 2014-08-22 01:14:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 01:14:56]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[weiliangc, 2014-08-22 14:37:24]

The CQ bit was checked by weiliangc@chromium.org

[commit-bot: I haz the power, 2014-08-22 14:37:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/weiliangc@chromium.org/404563005/140001

[commit-bot: I haz the power, 2014-08-22 14:42:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[commit-bot: I haz the power, 2014-08-22 14:51:01]

Committed patchset #8 (140001) as 291403

[tomhudson, 2014-08-22 14:55:20]

It's not at all clear how this CL relates to the bug cited?

[weiliangc, 2014-08-22 15:01:44]

On 2014/08/22 14:55:20, tomhudson wrote:
> It's not at all clear how this CL relates to the bug cited?

Without this a follow up CL to use custom code would create dependency cycle in
RenderPass and RenderPassDrawQuad. Follow up CL already touches a lot of files
so I want to separate this CL out.

Let me rewrite the description better.