Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 402133003: [cros, user_manager] Move default user images constants and helper functions out of src/chrome. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
Reviewers:
Bernhard Bauer, tony, oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[cros, user_manager] Move default user images constants and helper functions out of src/chrome. BUG=387614 TBR=bauerb@chromium.org, tony@chromium.org, oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284490

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : re-format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+521 lines, -493 lines) Patch
M chrome/browser/chromeos/login/screens/user_image_screen.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 3 chunks +8 lines, -5 lines 0 comments Download
D chrome/browser/chromeos/login/users/avatar/default_user_images.h View 1 chunk +0 lines, -86 lines 0 comments Download
D chrome/browser/chromeos/login/users/avatar/default_user_images.cc View 1 chunk +0 lines, -286 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc View 11 chunks +58 lines, -36 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc View 8 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/users/avatar/user_image_sync_observer.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/users/user.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A chrome/browser/supervised_user/DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/supervised_user_creation_screen_handler.cc View 1 chunk +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc View 8 chunks +31 lines, -24 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/user_manager.gypi View 2 chunks +13 lines, -5 lines 0 comments Download
M components/user_manager/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
A components/user_manager/user_image/default_user_images.h View 1 chunk +78 lines, -0 lines 0 comments Download
A components/user_manager/user_image/default_user_images.cc View 1 2 1 chunk +258 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nikita (slow)
This is a third part of https://codereview.chromium.org/400973002/ which already got all lgtms so TBR'ing. TBR'ing ...
6 years, 5 months ago (2014-07-21 16:51:33 UTC) #1
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-21 17:06:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/402133003/40001
6 years, 5 months ago (2014-07-21 17:08:15 UTC) #3
tony
DEPS LGTM
6 years, 5 months ago (2014-07-21 17:23:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_rel_device on tryserver.chromium ...
6 years, 5 months ago (2014-07-21 19:14:35 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-21 19:58:00 UTC) #6
Message was sent while issue was closed.
Change committed as 284490

Powered by Google App Engine
This is Rietveld 408576698